Page MenuHomeFreeBSD
Differential D38555

cpuset: Add compat shim to the sched_affinity functions
ClosedPublic
Actions

Authored by dchagin on Feb 13 2023, 11:40 AM.
Tags
None
Referenced Files
F143807990: D38555.id117281.diff
Sat, Jan 31, 2:41 PM
F143772936: D38555.id117192.diff
Sat, Jan 31, 12:25 PM
Unknown Object (File)
Sat, Jan 31, 3:16 AM
Unknown Object (File)
Fri, Jan 30, 8:24 PM
Unknown Object (File)
Sun, Jan 25, 9:15 AM
Unknown Object (File)
Sun, Jan 18, 11:29 AM
Unknown Object (File)
Tue, Jan 13, 2:16 PM
Unknown Object (File)
Dec 31 2025, 4:09 AM
View All Files
Subscribers
imp

Details

Reviewers
kib
Commits
rGf3f350c5c8e4: cpuset: Add compat shim to the sched_affinity functions
rGcbc32e4c5e84: cpuset: Add compat shim to the sched_affinity functions
Summary

To allow to run a new world on the pre 1400079 kernel a compat shims to
the sched_affinity functions has beed added. PID_MAX is hardcoded as our
kernel does not expose it to the user space.

Reported by: antoine
Tested by: antoine

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 49729
Build 46619: arc lint + arc unit

Event Timeline

dchagin created this revision.Feb 13 2023, 11:40 AM
Herald added a subscriber: imp. · View Herald TranscriptFeb 13 2023, 11:40 AM
dchagin requested review of this revision.Feb 13 2023, 11:40 AM
Harbormaster completed remote builds in B49729: Diff 117083.Feb 13 2023, 11:40 AM
dchagin edited the summary of this revision. (Show Details)Feb 13 2023, 3:59 PM
dchagin added a reviewer: kib.
kib added inline comments.Feb 14 2023, 12:41 AM
lib/libc/gen/sched_getaffinity.c
35

Look at sys/param.h P_OSREL_XXX macros.

dchagin updated this revision to Diff 117188.Feb 14 2023, 7:49 AM
dchagin edited the summary of this revision. (Show Details)

better (beauty) naming, thanks)

Harbormaster completed remote builds in B49768: Diff 117188.Feb 14 2023, 7:49 AM
kib added a comment.Feb 14 2023, 8:04 AM
In D38555#877823, @dchagin wrote:

better (beauty) naming, thanks)

Um, I mean that you should add your P_OSREL value to sys/param.h

dchagin added a comment.Feb 14 2023, 8:31 AM
In D38555#877827, @kib wrote:
In D38555#877823, @dchagin wrote:

better (beauty) naming, thanks)

Um, I mean that you should add your P_OSREL value to sys/param.h

sure? P_OSREL is under _KERNEL, thats why I do not do it

dchagin updated this revision to Diff 117192.Feb 14 2023, 11:07 AM

_WANT_OSREL use

Harbormaster completed remote builds in B49770: Diff 117192.Feb 14 2023, 11:07 AM
kib added inline comments.Feb 15 2023, 1:04 AM
lib/libc/gen/sched_getaffinity.c
35

I would move this definition into libc_private.h, and add a comment explaining why we hardcode the value there.

dchagin updated this revision to Diff 117281.Feb 15 2023, 9:12 AM

done, may be put _PID_MAX under _WANT_P_OSREL condition?

Harbormaster completed remote builds in B49796: Diff 117281.Feb 15 2023, 9:12 AM
kib accepted this revision.Feb 15 2023, 9:17 AM
In D38555#878467, @dchagin wrote:

done, may be put _PID_MAX under _WANT_P_OSREL condition?

No, they are unrelated.

lib/libc/include/libc_private.h
47 ↗(On Diff #117281)

Add a blank line before this comment.

This revision is now accepted and ready to land.Feb 15 2023, 9:17 AM
Closed by commit rGcbc32e4c5e84: cpuset: Add compat shim to the sched_affinity functions (authored by dchagin). · Explain WhyFeb 15 2023, 9:24 AM
This revision was automatically updated to reflect the committed changes.
dchagin added a commit: rGcbc32e4c5e84: cpuset: Add compat shim to the sched_affinity functions.
dchagin added a commit: rGf3f350c5c8e4: cpuset: Add compat shim to the sched_affinity functions.Feb 19 2023, 7:26 AM

Revision Contents
Changeset List

PathSize
lib/
libc/
gen/
16 lines
16 lines

Diff 117083

View Options

lib/libc/gen/sched_getaffinity.c

Loading...
View Options

lib/libc/gen/sched_setaffinity.c

Loading...