xlocale: garbage collect references to strtoq_l/strtouq_l
ClosedPublic
Actions

Authored by val_packett.cool on Feb 6 2023, 7:47 PM.

Details

Reviewers

theraven
emaste

Group Reviewers

Contributor Reviews (src)

Commits

rG939b24b0abbd: xlocale: garbage collect references to strtoq_l/strtouq_l

Summary

These were explicitly never implemented (see lib/libc/locale/DESIGN.xlocale), but were referenced in the manpage and the symbol map.

Fixes: 3c87aa1d3dc ("Implement xlocale APIs from Darwin")
Reported by: ld.lld 16 being --no-undefined-version by default
Sponsored by: https://www.patreon.com/valpackett

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 49574
Build 46464: arc lint + arc unit

Event Timeline

val_packett.cool created this revision.Feb 6 2023, 7:47 PM

Herald added a subscriber: imp. · View Herald TranscriptFeb 6 2023, 7:47 PM

val_packett.cool requested review of this revision.Feb 6 2023, 7:47 PM

Harbormaster completed remote builds in B49574: Diff 116640.Feb 6 2023, 7:47 PM

val_packett.cool edited the summary of this revision. (Show Details)Feb 6 2023, 7:48 PM

val_packett.cool added reviewers: Contributor Reviews (src), theraven, emaste.

LGTM. I thought we had those functions, but I've never seen any code in the wild using them, so if we don't then we should get rid of any reference to them.

This revision is now accepted and ready to land.Feb 8 2023, 11:52 AM

emaste accepted this revision.Mar 2 2023, 8:54 PM

Closed by commit rG939b24b0abbd: xlocale: garbage collect references to strtoq_l/strtouq_l (authored by val_packett.cool, committed by emaste). · Explain WhyMar 2 2023, 8:55 PM

This revision was automatically updated to reflect the committed changes.

emaste added a commit: rG939b24b0abbd: xlocale: garbage collect references to strtoq_l/strtouq_l.