Differential D38383

Add support for Huawei 4G Modem devices (2022)
Needs ReviewPublic
Actions

Authored by fbsd_paepcke.de on Feb 4 2023, 8:53 PM.

Details

Reviewers

imp

Summary

Add support for Huawei 4G Modem devices (2022)

add new Huawei 4G E3372_NCM (0x1505)
add new Huawei 4G E3372v153_NCM (0x155f)
add new Huawei 4G E5573Cs322_NCM (0x155e)
add new Huawei 4G E5573Cs322_ECM (0x14db)
add new Huawei 4G E5573Cs322_ACM (0x1442)
remove Huawei 3G E3131 (E3131_INIT): frees up 0x1505/0x14fe shared IDs => product is EOL 3G networks are shutdown/scheduled E3131 devices will still work the same via eject2 new 4G devices will switch & report correctly now

Default all devices to simple NCM mode and get a consistent and reliable behavior. No matter what firmware version and provider mix are involved.

Fixing the root cause and bundle a working firmware for ECM is not possible. Huawei sells the same hardware, different (crippled) firmware versions at different price points in different markets as strategy.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

fbsd_paepcke.de requested review of this revision.Feb 4 2023, 8:53 PM

fbsd_paepcke.de created this revision.

My proposed commit chain can be seen at https://github.com/bsdimp/freebsd/pull/new/PR-633, including my best guess at the proper author.
Please comment on this review if that matches. I did some minor whitespace cleanups as well and I think I got the commit messages right and
clumped reasonably. Thanks.

This revision is now accepted and ready to land.Feb 4 2023, 9:05 PM

Oh! One more thing...

Can you update share/man/man4/u3g.4 to include these changes please?

This revision now requires changes to proceed.Feb 4 2023, 9:11 PM

In D38383#872617, @imp wrote:

Oh! One more thing...

Can you update share/man/man4/u3g.4 to include these changes please?

I'm unsure how to list these in the man page...

fbsd_paepcke.de updated this revision to Diff 116504.Feb 4 2023, 9:40 PM

In D38383#872620, @imp wrote:

In D38383#872617, @imp wrote:

Oh! One more thing...

Can you update share/man/man4/u3g.4 to include these changes please?

I'm unsure how to list these in the man page...

I have added a quick fix to add the types to the list.

I'm currently not 100% sure where to place some more
details how to use NCM/ECM modes. U3G just provides
the command ports, but the interfaces are build by CDC.

I will provide an proposal within the next 3 days how to
handle it