linux(4): Microoptimize rt_sendsig() on amd64.
ClosedPublic
Actions

Authored by dchagin on Feb 1 2023, 11:08 AM.

Details

Reviewers

Commits

rGb69b287a0969: linux(4): Microoptimize rt_sendsig() on amd64.
rG6ad07a4b2bdf: linux(4): Microoptimize rt_sendsig() on amd64.

Summary

Drop proc lock earlier, before copying user stuff.

Pointed out by: kib

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

dchagin created this revision.Feb 1 2023, 11:08 AM

Herald added a subscriber: imp. · View Herald TranscriptFeb 1 2023, 11:08 AM

dchagin requested review of this revision.Feb 1 2023, 11:08 AM

Harbormaster completed remote builds in B49398: Diff 116182.Feb 1 2023, 11:08 AM

in the expectation:
ksiginfo_t *ksi
sigset_t *mask
both are on stack and do not need to proc lock

kib added inline comments.Feb 1 2023, 8:23 PM

sys/amd64/linux/linux_sysvec.c
480	Strictly speaking, you can unlock right before this line.

sure, I left these lines together as a unit of code for sp,
now done.

Harbormaster completed remote builds in B49428: Diff 116228.Feb 1 2023, 9:21 PM

kib accepted this revision.Feb 1 2023, 9:28 PM

This revision is now accepted and ready to land.Feb 1 2023, 9:28 PM

Closed by commit rG6ad07a4b2bdf: linux(4): Microoptimize rt_sendsig() on amd64. (authored by dchagin). · Explain WhyFeb 2 2023, 5:22 PM

This revision was automatically updated to reflect the committed changes.

dchagin added a commit: rG6ad07a4b2bdf: linux(4): Microoptimize rt_sendsig() on amd64..

dchagin added a commit: rGb69b287a0969: linux(4): Microoptimize rt_sendsig() on amd64..Feb 9 2023, 7:57 AM

Revision Contents
Changeset List

Path

Size

sys/

amd64/

linux/

linux_sysvec.c

34 lines

Diff 116345

View Options

sys/amd64/linux/linux_sysvec.c

linux(4): Microoptimize rt_sendsig() on amd64.ClosedPublicActions