Page MenuHomeFreeBSD
Differential D38326

linux(4): Microoptimize rt_sendsig() on amd64.
ClosedPublic
Actions

Authored by dchagin on Feb 1 2023, 11:08 AM.
Tags
None
Referenced Files
F154399325: D38326.id.diff
Tue, Apr 28, 8:39 AM
F154394708: D38326.id116182.diff
Tue, Apr 28, 8:04 AM
Unknown Object (File)
Mon, Apr 27, 3:59 AM
Unknown Object (File)
Fri, Apr 24, 5:49 AM
Unknown Object (File)
Mon, Apr 20, 12:11 AM
Unknown Object (File)
Sun, Apr 19, 8:11 PM
Unknown Object (File)
Thu, Apr 16, 4:33 PM
Unknown Object (File)
Tue, Apr 14, 8:36 PM
View All Files
Subscribers
imp

Details

Reviewers
kib
Commits
rGb69b287a0969: linux(4): Microoptimize rt_sendsig() on amd64.
rG6ad07a4b2bdf: linux(4): Microoptimize rt_sendsig() on amd64.
Summary

Drop proc lock earlier, before copying user stuff.

Pointed out by: kib

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 49398
Build 46288: arc lint + arc unit

Event Timeline

dchagin created this revision.Feb 1 2023, 11:08 AM
Herald added a subscriber: imp. · View Herald TranscriptFeb 1 2023, 11:08 AM
dchagin requested review of this revision.Feb 1 2023, 11:08 AM
Harbormaster completed remote builds in B49398: Diff 116182.Feb 1 2023, 11:08 AM
dchagin added a reviewer: kib.Feb 1 2023, 11:13 AM

in the expectation:
ksiginfo_t *ksi
sigset_t *mask
both are on stack and do not need to proc lock

kib added inline comments.Feb 1 2023, 8:23 PM
sys/amd64/linux/linux_sysvec.c
481

Strictly speaking, you can unlock right before this line.

dchagin updated this revision to Diff 116228.Feb 1 2023, 9:21 PM

sure, I left these lines together as a unit of code for sp,
now done.

Harbormaster completed remote builds in B49428: Diff 116228.Feb 1 2023, 9:21 PM
kib accepted this revision.Feb 1 2023, 9:28 PM
This revision is now accepted and ready to land.Feb 1 2023, 9:28 PM
Closed by commit rG6ad07a4b2bdf: linux(4): Microoptimize rt_sendsig() on amd64. (authored by dchagin). · Explain WhyFeb 2 2023, 5:22 PM
This revision was automatically updated to reflect the committed changes.
dchagin added a commit: rG6ad07a4b2bdf: linux(4): Microoptimize rt_sendsig() on amd64..
dchagin added a commit: rGb69b287a0969: linux(4): Microoptimize rt_sendsig() on amd64..Feb 9 2023, 7:57 AM

Revision Contents
Changeset List

PathSize
sys/
amd64/
linux/
32 lines

Diff 116182

View Options

sys/amd64/linux/linux_sysvec.c

Loading...