PR: 240768
Details
Details
openssl speed rsa
Diff Detail
Diff Detail
- Repository
- rG FreeBSD src repository
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 49369 Build 46259: arc lint + arc unit
Event Timeline
| sys/amd64/linux/linux_sysvec.c | ||
|---|---|---|
| 511 | ||
| 523 | Could 10 be replaced by some symbolic expression like sizeof()? Same question for 8 and 16, above and below. | |
| sys/x86/linux/linux_x86_sigframe.h | ||
| 150 | So what would we do when Linux starts using that space? In fact I believe that you do not need to save any of these fields. When restroring context, set owned to _MC_FPOWNED_FPU, mc_fpformat to _MC_FPFMT_XMM, and flags to _MX_HASFPXSTATE, | |
Comment Actions
bad idea to put mc_ field at the end of the reserved area in the struct fpstate,
as here potential extended state is encoded.
put it at the start
| sys/amd64/linux/linux_sysvec.c | ||
|---|---|---|
| 401 | ||
| 417 | nitems | |
| 422 | nitems | |
| 504 | I believe the ps_mtx and proc lock can be dropped after this line, there is no point of copying all the stuff under the locks. Even more, the code be re-arranged to do all accesses to lock-protected members earlier. But this is perhaps is not too important. | |
| 522 | sizeof(svfp->sv_fp) / sizeof(svfp->sv_fp[0]) is better spelled as nitems(sizeof(svfp->sv_fp)) | |
| 527 | Same | |