Page MenuHomeFreeBSD
Differential D37937

wdatwd: fix i386 build breakage.
ClosedPublic
Actions

Authored by takawata on Jan 3 2023, 11:33 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Nov 25, 2:52 PM
Unknown Object (File)
Wed, Nov 19, 10:16 AM
Unknown Object (File)
Mon, Nov 17, 6:24 PM
Unknown Object (File)
Fri, Nov 14, 5:11 AM
Unknown Object (File)
Sun, Nov 9, 3:39 PM
Unknown Object (File)
Tue, Nov 4, 1:58 PM
Unknown Object (File)
Tue, Nov 4, 1:53 PM
Unknown Object (File)
Tue, Nov 4, 1:53 PM
View All Files
Subscribers
imp

Details

Reviewers
hrs
Commits
rGeb03c1f81cbc: wdatwd: fix i386 build breakage.
Summary

Formatting string for uint64_t has portablity issue and
lead bulid breakage so fix it.

Test Plan

compile module both i386 and amd64

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 48946
Build 45835: arc lint + arc unit

Event Timeline

takawata created this revision.Jan 3 2023, 11:33 PM
Herald added a subscriber: imp. · View Herald TranscriptJan 3 2023, 11:33 PM
takawata requested review of this revision.Jan 3 2023, 11:33 PM
Harbormaster completed remote builds in B48946: Diff 114738.Jan 3 2023, 11:33 PM
hrs accepted this revision.Jan 4 2023, 12:53 AM
hrs added inline comments.
sys/dev/wdatwd/wdatwd.c
366

This might be a matter of preference, but %ju and type casting by (uintmax_t) would be simpler.

681

Same here. %jx, in this case.

This revision is now accepted and ready to land.Jan 4 2023, 12:53 AM
Closed by commit rGeb03c1f81cbc: wdatwd: fix i386 build breakage. (authored by takawata). · Explain WhyJan 4 2023, 1:05 AM
This revision was automatically updated to reflect the committed changes.
takawata added a commit: rGeb03c1f81cbc: wdatwd: fix i386 build breakage..

Revision Contents
Changeset List

PathSize
sys/
dev/
wdatwd/
21 lines

Diff 114738

View Options

sys/dev/wdatwd/wdatwd.c

Loading...