Page MenuHomeFreeBSD
Differential D37754

Bug 268310 - update sizeof.7
Needs ReviewPublic
Actions

Authored by jschauma_netmeister.org on Dec 20 2022, 2:32 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Apr 7, 4:44 PM
Unknown Object (File)
Mar 11 2024, 1:11 AM
Unknown Object (File)
Jan 5 2024, 5:44 PM
Unknown Object (File)
Dec 25 2023, 5:12 PM
Unknown Object (File)
Dec 23 2023, 2:08 AM
Unknown Object (File)
Dec 13 2023, 4:18 PM
Unknown Object (File)
Dec 1 2023, 7:35 AM
Unknown Object (File)
Nov 30 2023, 5:16 PM
View All 41 Files
Subscribers
imp

Details

Reviewers
kib
Summary

After the initial commit in Bug 268310 was made, additional changes went into https://reviews.freebsd.org/D37674.

This diff applies the final changes from that review.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

jschauma_netmeister.org created this revision.Dec 20 2022, 2:32 AM
Herald added a subscriber: imp. · View Herald TranscriptDec 20 2022, 2:32 AM
jschauma_netmeister.org requested review of this revision.Dec 20 2022, 2:32 AM
kib added a comment.Dec 20 2022, 2:39 AM

When uploading patch to phabricator, please generate full context (e.g. git diff -U999999 ...).

share/man/man7/sizeof.7
237

Why changing .In to .Dv ?

261

This is not the the diff against current sources.

jschauma_netmeister.org updated this revision to Diff 114304.Dec 20 2022, 2:43 AM

Diff against https://cgit.freebsd.org/src/plain/share/man/man7/sizeof.7 (hopefully correctly, this time).

jschauma_netmeister.org updated this revision to Diff 114305.Dec 20 2022, 2:45 AM

Minimize diff.

jschauma_netmeister.org added a comment.Dec 20 2022, 2:54 AM

I don't have the repository checked out right now (was working off the web-ui). Based on https://wiki.freebsd.org/GitWorkflow, I gather the recommended tree is the one from GitHub? I'll go and grab that one and will update here if the diff ends up different from what I just posted.

jschauma_netmeister.org updated this revision to Diff 114306.Dec 20 2022, 3:00 AM

Full context diff (git diff -U999999).

jschauma_netmeister.org updated this revision to Diff 114307.Dec 20 2022, 3:01 AM

Full context diff (second try, I guess).

jschauma_netmeister.org added a comment.Dec 20 2022, 4:02 AM

You know what, you can ditch this review. The changes in-tree diverged or superseded already from what was in https://reviews.freebsd.org/D37674.

Revision Contents
Changeset List

PathSize
share/
man/
man7/
55 lines

Diff 114306

View Options

share/man/man7/sizeof.7

Loading...