riscv: always include frame pointer
ClosedPublic
Actions

Authored by mhorne on Dec 9 2022, 6:50 PM.

Details

Reviewers

jhb

Group Reviewers

riscv

Commits

rG217c99d12a74: riscv: always include frame pointer
rGb926b6db37f3: riscv: always include frame pointer

Summary

Specifically it is missing in kernel modules, meaning a proper backtrace
can't be constructed.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 48680
Build 45566: arc lint + arc unit

Event Timeline

mhorne created this revision.Dec 9 2022, 6:50 PM

Herald added a subscriber: imp. · View Herald TranscriptDec 9 2022, 6:50 PM

mhorne requested review of this revision.Dec 9 2022, 6:50 PM

Harbormaster completed remote builds in B48680: Diff 114014.Dec 9 2022, 6:50 PM

I wish DTR_ENABLED was spelled as something more obvious like DTRACE_ENABLED. I had to go grep to figure out what it means.

This revision is now accepted and ready to land.Dec 9 2022, 6:54 PM

Closed by commit rGb926b6db37f3: riscv: always include frame pointer (authored by mhorne). · Explain WhyJan 12 2023, 3:08 PM

This revision was automatically updated to reflect the committed changes.

mhorne added a commit: rGb926b6db37f3: riscv: always include frame pointer.

mhorne added a commit: rG217c99d12a74: riscv: always include frame pointer.Jan 23 2023, 4:46 PM

Revision Contents
Changeset List

Path

Size

sys/

conf/

Makefile.riscv

2 lines

kmod.mk

3 lines

Diff 114014

View Options

sys/conf/Makefile.riscv