Page MenuHomeFreeBSD
Differential D37634

devel/cl-asdf: Update to 3.3.7
ClosedPublic
Actions

Authored by jrm on Dec 8 2022, 5:06 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Apr 9, 11:19 AM
Unknown Object (File)
Wed, Apr 9, 11:07 AM
Unknown Object (File)
Wed, Apr 9, 8:53 AM
Unknown Object (File)
Wed, Apr 9, 5:37 AM
Unknown Object (File)
Wed, Apr 9, 4:13 AM
Unknown Object (File)
Wed, Apr 9, 4:12 AM
Unknown Object (File)
Wed, Apr 9, 4:11 AM
Unknown Object (File)
Wed, Apr 9, 4:09 AM
View All 64 Files
Subscribers
emaste
mat

Details

Reviewers
olgeni
ashish
krion
Commits
R11:0c35c3d61d20: devel/cl-asdf: Update to 3.3.7
Summary

Also:

  • resolve warnings from SBCL about the ASDF port being outdated and subsequently disabled [0] by installing version.lisp-expr
  • re-add the devel/cl-asdf-sbcl port to the tree in a subsequent commit because it is required to avoid filesystem violation errors when building *-sbcl ports with Poudriere.

[0]

WARNING: You are using ASDF version 3.3.1 (probably from (require "asdf") or loaded by quicklisp) and have an older version of ASDF (and older than 2.27 at that) registered at #P"/usr/local/lib/common-lisp/asdf/asdf.asd". Having an ASDF installed and registered is the normal way of configuring ASDF to upgrade itself, and having an old version registered is a configuration error. ASDF will ignore this configured system rather than downgrade itself. In the future, you may want to either: (a) upgrade this configured ASDF to a newer version, (b) install a newer ASDF and register it in front of the former in your configuration, or (c) uninstall or unregister this and any other old version of ASDF from your configuration. Note that the older ASDF might be registered implicitly through configuration inherited from your system installation, in which case you might have to specify :ignore-inherited-configuration in your in your ~/.config/common-lisp/source-registry.conf or other source-registry configuration file, environment variable or lisp parameter. Indeed, a likely offender is an obsolete version of the cl-asdf debian or ubuntu package, that you might want to upgrade (if a recent enough version is available) or else remove altogether (since most implementations ship with a recent asdf); if you lack the system administration rights to upgrade or remove this package, then you might indeed want to either install and register a more recent version, or use :ignore-inherited-configuration to avoid registering the old one. Please consult ASDF documentation and/or experts.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 48651
Build 45537: arc lint + arc unit

Event Timeline

jrm created this revision.Dec 8 2022, 5:06 PM
Herald added a subscriber: mat. · View Herald TranscriptDec 8 2022, 5:06 PM
jrm requested review of this revision.Dec 8 2022, 5:06 PM
Harbormaster completed remote builds in B48651: Diff 113942.Dec 8 2022, 5:06 PM
jrm updated this revision to Diff 113947.Dec 8 2022, 6:57 PM

Remove some commented code in asdf-init.lisp

Harbormaster completed remote builds in B48652: Diff 113947.Dec 8 2022, 6:57 PM
jrm updated this revision to Diff 113954.Dec 8 2022, 10:29 PM

devel/cl-asdf-sbcl: New port to install ASDF FASL for SBCL

With a few tweaks to devel/cl-asdf and re-adding devel/cl-asdf-sbcl, our common
lisp ports behave as before, unless certain conditions are not met.

Details:

  • lang/sbcl has its own bundled asdf, but it still depends on devel/cl-asdf, presumably because devel-cl-asdf installs ${LOCALBASE}/etc/asdf-init.lisp.
  • If we install (the updated) devel/cl-asdf without also installing (the re-added) devel/cl-asdf-sbcl, ASDF will start trying to write files under ${LOCALBASE}/lib/common-lisp on users' systems.
  • lang/sbcl cannot depend on devel/cl-asdf-sbcl, because this would create a dependency loop.

With this update, users can get into trouble if they install some lisp port
without also installing the assocaited fasl port. If they don't, we're back to
having asdf trying to write things under ${LOCALBASE}/lib/common-lisp.

I will take more time to look deeper into the ASDF code and documentation to see
what the best way is to eiter tell it to stop automatically building the fasl
files, or build and install everything under the user's home directory.

If we did want remove SBCL's dependecy on devel/cl-asdf, perhaps we could
decouple devel/cl-asdf and asdf-init.lisp and create a new port to just install
the configuration.

Harbormaster completed remote builds in B48656: Diff 113954.Dec 8 2022, 10:29 PM
jrm added a reviewer: krion.Dec 8 2022, 10:36 PM
jrm updated this revision to Diff 146837.Nov 22 2024, 3:29 PM

Update to 3.3.7 and re-add devel/cl-asdf-sbcl to the tree

Harbormaster completed remote builds in B60726: Diff 146837.Nov 22 2024, 3:29 PM
jrm retitled this revision from devel/cl-asdf: [WIP] Update to 3.3.6 to devel/cl-asdf: Update to 3.3.7.Nov 22 2024, 3:32 PM
jrm edited the summary of this revision. (Show Details)
jrm updated this revision to Diff 146849.Nov 22 2024, 8:24 PM
jrm edited the summary of this revision. (Show Details)

devel/cl-asdf-sbcl: Prevent the fasl file from being installed under the build/ directory.

Harbormaster completed remote builds in B60735: Diff 146849.Nov 22 2024, 8:24 PM
jrm updated this revision to Diff 147685.Dec 8 2024, 12:01 AM

Split changes into multiple reviews

Harbormaster completed remote builds in B61026: Diff 147685.Dec 8 2024, 12:01 AM
emaste added a subscriber: emaste.Dec 10 2024, 4:10 PM
jrm updated this revision to Diff 147982.Dec 15 2024, 5:52 PM

Handle removal of asdf-init.lisp

Harbormaster completed remote builds in B61171: Diff 147982.Dec 15 2024, 5:52 PM
This revision was not accepted when it landed; it landed in state Needs Review.Dec 20 2024, 2:48 AM
Closed by commit R11:0c35c3d61d20: devel/cl-asdf: Update to 3.3.7 (authored by jrm). · Explain Why
This revision was automatically updated to reflect the committed changes.
jrm added a commit: R11:0c35c3d61d20: devel/cl-asdf: Update to 3.3.7.

Revision Contents
Changeset List

PathSize
devel/
cl-asdf/
32 lines
6 lines
files/
32 lines
78 lines

Diff 113942

View Options

devel/cl-asdf/Makefile

Show First 20 Lines • Show All 74 Lines • ▼ Show 20 Lines
done done
umask 377 umask 377
n=$(( ${entropy_save_num} - 1 )) n=$(( ${entropy_save_num} - 1 ))
while [ ${n} -ge 1 ]; do while [ ${n} -ge 1 ]; do
if [ -f "saved-entropy.${n}" ]; then if [ -f "saved-entropy.${n}" ]; then
mv "saved-entropy.${n}" "saved-entropy.$(( ${n} + 1 ))" mv "saved-entropy.${n}" "saved-entropy.$(( ${n} + 1 ))"
elif [ -e "saved-entropy.${n}" -o -L "saved-entropy.${n}" ]; then elif [ -e "saved-entropy.${n}" -o -L "saved-entropy.${n}" ]; then
delphijUnsubmitted
Not Done
Inline Actions

fsync'ing the directory node would result in more writes and I think we can tolerate if it failed to sync.

delphij: fsync'ing the directory node would result in more writes and I think we can tolerate if it…
cemAuthorUnsubmitted
Done
Inline Actions

If a small number of additional writes is a problem, and we can tolerate losing every rotated file (by lost dirent reference), I propose that we can save even more writes by keeping only one entropy file.

cem: If a small number of additional writes is a problem, and we can tolerate losing every rotated…
logger -is -t "$0" \ logger -is -t "$0" \
"${entropy_dir}/saved-entropy.${n}" is not a regular file, and so \ "${entropy_dir}/saved-entropy.${n}" is not a regular file, and so \
it will not be rotated. Entropy file rotation is aborted. it will not be rotated. Entropy file rotation is aborted.
exit 1 exit 1
fi fi
n=$(( ${n} - 1 )) n=$(( ${n} - 1 ))
done done
dd if=/dev/random of=saved-entropy.1 bs=${entropy_save_sz} count=1 2>/dev/null dd if=/dev/random of=saved-entropy.1 bs=${entropy_save_sz} count=1 2>/dev/null
fsync saved-entropy.1 "."
delphijUnsubmitted
Done
Inline Actions

This can be merged with the '.' (fsync saved-entropy.1 .).

delphij: This can be merged with the '.' (fsync saved-entropy.1 .).
cemAuthorUnsubmitted
Done
Inline Actions

Ah, I did not realize fsync(1) took a list of files! Thank you, I'll fix it.

cem: Ah, I did not realize fsync(1) took a list of files! Thank you, I'll fix it.
exit 0 exit 0
View Options

devel/cl-asdf/distinfo

Show First 20 Lines • Show All 74 Lines • ▼ Show 20 Lines
done done
umask 377 umask 377
n=$(( ${entropy_save_num} - 1 )) n=$(( ${entropy_save_num} - 1 ))
while [ ${n} -ge 1 ]; do while [ ${n} -ge 1 ]; do
if [ -f "saved-entropy.${n}" ]; then if [ -f "saved-entropy.${n}" ]; then
mv "saved-entropy.${n}" "saved-entropy.$(( ${n} + 1 ))" mv "saved-entropy.${n}" "saved-entropy.$(( ${n} + 1 ))"
elif [ -e "saved-entropy.${n}" -o -L "saved-entropy.${n}" ]; then elif [ -e "saved-entropy.${n}" -o -L "saved-entropy.${n}" ]; then
delphijUnsubmitted
Not Done
Inline Actions

fsync'ing the directory node would result in more writes and I think we can tolerate if it failed to sync.

delphij: fsync'ing the directory node would result in more writes and I think we can tolerate if it…
cemAuthorUnsubmitted
Done
Inline Actions

If a small number of additional writes is a problem, and we can tolerate losing every rotated file (by lost dirent reference), I propose that we can save even more writes by keeping only one entropy file.

cem: If a small number of additional writes is a problem, and we can tolerate losing every rotated…
logger -is -t "$0" \ logger -is -t "$0" \
"${entropy_dir}/saved-entropy.${n}" is not a regular file, and so \ "${entropy_dir}/saved-entropy.${n}" is not a regular file, and so \
it will not be rotated. Entropy file rotation is aborted. it will not be rotated. Entropy file rotation is aborted.
exit 1 exit 1
fi fi
n=$(( ${n} - 1 )) n=$(( ${n} - 1 ))
done done
dd if=/dev/random of=saved-entropy.1 bs=${entropy_save_sz} count=1 2>/dev/null dd if=/dev/random of=saved-entropy.1 bs=${entropy_save_sz} count=1 2>/dev/null
fsync saved-entropy.1 "."
delphijUnsubmitted
Done
Inline Actions

This can be merged with the '.' (fsync saved-entropy.1 .).

delphij: This can be merged with the '.' (fsync saved-entropy.1 .).
cemAuthorUnsubmitted
Done
Inline Actions

Ah, I did not realize fsync(1) took a list of files! Thank you, I'll fix it.

cem: Ah, I did not realize fsync(1) took a list of files! Thank you, I'll fix it.
exit 0 exit 0
View Options

devel/cl-asdf/files/asdf-init.lisp

Show First 20 Lines • Show All 74 Lines • ▼ Show 20 Lines
done done
umask 377 umask 377
n=$(( ${entropy_save_num} - 1 )) n=$(( ${entropy_save_num} - 1 ))
while [ ${n} -ge 1 ]; do while [ ${n} -ge 1 ]; do
if [ -f "saved-entropy.${n}" ]; then if [ -f "saved-entropy.${n}" ]; then
mv "saved-entropy.${n}" "saved-entropy.$(( ${n} + 1 ))" mv "saved-entropy.${n}" "saved-entropy.$(( ${n} + 1 ))"
elif [ -e "saved-entropy.${n}" -o -L "saved-entropy.${n}" ]; then elif [ -e "saved-entropy.${n}" -o -L "saved-entropy.${n}" ]; then
delphijUnsubmitted
Not Done
Inline Actions

fsync'ing the directory node would result in more writes and I think we can tolerate if it failed to sync.

delphij: fsync'ing the directory node would result in more writes and I think we can tolerate if it…
cemAuthorUnsubmitted
Done
Inline Actions

If a small number of additional writes is a problem, and we can tolerate losing every rotated file (by lost dirent reference), I propose that we can save even more writes by keeping only one entropy file.

cem: If a small number of additional writes is a problem, and we can tolerate losing every rotated…
logger -is -t "$0" \ logger -is -t "$0" \
"${entropy_dir}/saved-entropy.${n}" is not a regular file, and so \ "${entropy_dir}/saved-entropy.${n}" is not a regular file, and so \
it will not be rotated. Entropy file rotation is aborted. it will not be rotated. Entropy file rotation is aborted.
exit 1 exit 1
fi fi
n=$(( ${n} - 1 )) n=$(( ${n} - 1 ))
done done
dd if=/dev/random of=saved-entropy.1 bs=${entropy_save_sz} count=1 2>/dev/null dd if=/dev/random of=saved-entropy.1 bs=${entropy_save_sz} count=1 2>/dev/null
fsync saved-entropy.1 "."
delphijUnsubmitted
Done
Inline Actions

This can be merged with the '.' (fsync saved-entropy.1 .).

delphij: This can be merged with the '.' (fsync saved-entropy.1 .).
cemAuthorUnsubmitted
Done
Inline Actions

Ah, I did not realize fsync(1) took a list of files! Thank you, I'll fix it.

cem: Ah, I did not realize fsync(1) took a list of files! Thank you, I'll fix it.
exit 0 exit 0
View Options

devel/cl-asdf/pkg-plist

Show First 20 Lines • Show All 74 Lines • ▼ Show 20 Lines
done done
umask 377 umask 377
n=$(( ${entropy_save_num} - 1 )) n=$(( ${entropy_save_num} - 1 ))
while [ ${n} -ge 1 ]; do while [ ${n} -ge 1 ]; do
if [ -f "saved-entropy.${n}" ]; then if [ -f "saved-entropy.${n}" ]; then
mv "saved-entropy.${n}" "saved-entropy.$(( ${n} + 1 ))" mv "saved-entropy.${n}" "saved-entropy.$(( ${n} + 1 ))"
elif [ -e "saved-entropy.${n}" -o -L "saved-entropy.${n}" ]; then elif [ -e "saved-entropy.${n}" -o -L "saved-entropy.${n}" ]; then
delphijUnsubmitted
Not Done
Inline Actions

fsync'ing the directory node would result in more writes and I think we can tolerate if it failed to sync.

delphij: fsync'ing the directory node would result in more writes and I think we can tolerate if it…
cemAuthorUnsubmitted
Done
Inline Actions

If a small number of additional writes is a problem, and we can tolerate losing every rotated file (by lost dirent reference), I propose that we can save even more writes by keeping only one entropy file.

cem: If a small number of additional writes is a problem, and we can tolerate losing every rotated…
logger -is -t "$0" \ logger -is -t "$0" \
"${entropy_dir}/saved-entropy.${n}" is not a regular file, and so \ "${entropy_dir}/saved-entropy.${n}" is not a regular file, and so \
it will not be rotated. Entropy file rotation is aborted. it will not be rotated. Entropy file rotation is aborted.
exit 1 exit 1
fi fi
n=$(( ${n} - 1 )) n=$(( ${n} - 1 ))
done done
dd if=/dev/random of=saved-entropy.1 bs=${entropy_save_sz} count=1 2>/dev/null dd if=/dev/random of=saved-entropy.1 bs=${entropy_save_sz} count=1 2>/dev/null
fsync saved-entropy.1 "."
delphijUnsubmitted
Done
Inline Actions

This can be merged with the '.' (fsync saved-entropy.1 .).

delphij: This can be merged with the '.' (fsync saved-entropy.1 .).
cemAuthorUnsubmitted
Done
Inline Actions

Ah, I did not realize fsync(1) took a list of files! Thank you, I'll fix it.

cem: Ah, I did not realize fsync(1) took a list of files! Thank you, I'll fix it.
exit 0 exit 0