This review contains changes to add ports of py-qt6.
This compiles fine in poudriere, I still have not run tested it.
Details
Details
- Reviewers
tcberner lbartoletti fluffy - Group Reviewers
portmgr - Commits
- R11:bac27439dc2f: */*pyqt*: Add pyqt6 ports
I need to run test it on a virtual machine at least.
Diff Detail
Diff Detail
- Repository
- rP FreeBSD ports repository
- Lint
No Lint Coverage - Unit
No Test Coverage - Build Status
Buildable 48072 Build 44959: arc lint + arc unit
Event Timeline
Comment Actions
Awesome!
| devel/py-qt6-qscintilla2/pkg-descr | ||
|---|---|---|
| 4 | ^ you could remove this here and append it to the WWW in the Makefile | |
Comment Actions
py-qt5-sip seems to be broken:
===> py39-qt5-sip-12.9.1 depends on file: /usr/local/sbin/pkg - found => .tar.gz is not in /usr/ports/devel/py-qt5-sip/distinfo. => Either /usr/ports/devel/py-qt5-sip/distinfo is out of date, or => .tar.gz is spelled incorrectly.
Comment Actions
Oh, thanks, the error with py-qt5-sip is due to having forgotten to change the variable name in the port Makefile to PYQT5SIP_DISTNAME. I'm going to fix that.
But this exposes I clearly did not properly test for regressions with py-qt5. I'm going to do that, but it will require some time.
Comment Actions
You could also do something like
pyqt.mk:
PYQT5SIP_DISTNAME= ...
PYQT6SIP_DISTANME=...
PYQTSIP_DISTNAME=${PYQT${_PYQTVER}_DISTNAME}That whay the ports can stay the same and look mostly alike for 5 and 6 -- i.e. expose unversioned variables -- we do something similar in qt.mk for example.
Comment Actions
- Rebased on latest ports tree.
- Tested with Python 3.10, seems to work, so I modified the restricitons.
- Changed varibales to use unversioned ones where possiblle, could not find a solution for sip:
To explain, since Uses/pyqt.mk also accepts a :sip argument in place of the major version number, qhen compiling sip there is no reasonable value in _PYQT_VERSION. So for the sip ports I kept the versioned variables.
Comment Actions
devel/py-qt5-pyqt@py311 has an issue:
===> Checking for items in STAGEDIR missing from pkg-plist Error: Orphaned: %%PYTHON_SITELIBDIR%%/PyQt5/bindings/QtCore/pyqt-gpl.sip5 ===> Checking for items in pkg-plist which are not in STAGEDIR ===> Error: Plist issues found. *** Error code 1
Comment Actions
This is also happening in the official tree, I just tested:
====> Running Q/A tests (stage-qa)
Warning: 'lib/python3.9/site-packages/dbus/mainloop/pyqt5.abi3.so' is not stripped consider trying INSTALL_TARGET=install-strip or using ${STRIP_CMD}
Error: /usr/local/lib/python3.9/site-packages/PyQt5/QtBluetooth.abi3.so is linked to /usr/local/lib/libGL.so.1 from graphics/libglvnd but it is not declared as a dependency
Warning: you need USE_GL+=gl
====> Checking for pkg-plist issues (check-plist)
===> Parsing plist
===> Checking for items in STAGEDIR missing from pkg-plist
Error: Orphaned: %%PYTHON_SITELIBDIR%%/PyQt5/bindings/QtCore/pyqt-gpl.sip5
===> Checking for items in pkg-plist which are not in STAGEDIR
===> Error: Plist issues found.
*** Error code 1
Stop.
make: stopped in /usr/ports/devel/py-qt5-pyqt
=>> Error: check-plist failures detectedI'm filing a patch to bugzilla shortly for the plist part. For the fl dependency I'm not sure, it requires further investigation.
Comment Actions
I think it looks good from my side -- unless @lbartoletti has some concerns, feel free to land this :)