Uses/cmake.mk: Always pass FETCHCONTENT_FULLY_DISCONNECTED=1 to CMAKE_ARGS.
ClosedPublic
Actions

Authored by arrowd on Oct 17 2022, 8:09 AM.

Details

Reviewers

Group Reviewers

kde
portmgr

Commits

R11:33ec243a799f: Uses/cmake.mk: Always pass FETCHCONTENT_FULLY_DISCONNECTED=1 to CMAKE_ARGS.

Summary

This variable makes FetchContent_*() CMake functions to disable any network
access, which is exactly what we expect in Ports framework.

Test Plan

poudriere testport on a simple CMake port.

Diff Detail

Repository

rP FreeBSD ports repository

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 47854
Build 44741: arc lint + arc unit

Event Timeline

arrowd created this revision.Oct 17 2022, 8:09 AM

Herald added a reviewer: portmgr. · View Herald TranscriptOct 17 2022, 8:09 AM

Herald added a subscriber: mat. · View Herald Transcript

arrowd requested review of this revision.Oct 17 2022, 8:09 AM

Harbormaster completed remote builds in B47854: Diff 111850.Oct 17 2022, 8:09 AM

fluffy added a subscriber: fluffy.Oct 17 2022, 12:54 PM

Macro makeitso:

very nice :)

This revision is now accepted and ready to land.Oct 17 2022, 2:36 PM

Closed by commit R11:33ec243a799f: Uses/cmake.mk: Always pass FETCHCONTENT_FULLY_DISCONNECTED=1 to CMAKE_ARGS. (authored by arrowd). · Explain WhyOct 18 2022, 9:18 AM

This revision was automatically updated to reflect the committed changes.

arrowd added a commit: R11:33ec243a799f: Uses/cmake.mk: Always pass FETCHCONTENT_FULLY_DISCONNECTED=1 to CMAKE_ARGS..

Revision Contents
Changeset List

Path

Size

Mk/

Uses/

cmake.mk

3 lines

Diff 111850

View Options

Uses/cmake.mk: Always pass FETCHCONTENT_FULLY_DISCONNECTED=1 to CMAKE_ARGS.ClosedPublicActions