Page MenuHomeFreeBSD
Differential D36941

release: link from /boot/msdos to efi
ClosedPublic
Actions

Authored by imp on Oct 11 2022, 7:08 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Oct 6, 4:15 AM
Unknown Object (File)
Sat, Oct 3, 6:49 PM
Unknown Object (File)
Fri, Sep 25, 7:38 AM
Unknown Object (File)
Sep 10 2026, 4:39 AM
Unknown Object (File)
Sep 8 2026, 10:59 PM
Unknown Object (File)
Sep 5 2026, 8:05 AM
Unknown Object (File)
Sep 5 2026, 7:34 AM
Unknown Object (File)
Sep 5 2026, 5:54 AM
View All Files
Subscribers
andrew
markmi_dsl-only.net

Details

Reviewers
gjb
Commits
rG1be88beabb3c: release: link from /boot/msdos to efi
Summary

We need to do a relative link to efi instead of an absolute link into
the build tree.

Sponsored by: Netflix

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 47782
Build 44669: arc lint + arc unit

Event Timeline

imp created this revision.Oct 11 2022, 7:08 PM
Herald added a subscriber: andrew. · View Herald TranscriptOct 11 2022, 7:08 PM
imp requested review of this revision.Oct 11 2022, 7:08 PM
Harbormaster completed remote builds in B47782: Diff 111657.Oct 11 2022, 7:09 PM
markmi_dsl-only.net added a subscriber: markmi_dsl-only.net.Oct 11 2022, 7:15 PM

The update looks right to me.

gjb accepted this revision.Oct 11 2022, 7:18 PM
This revision is now accepted and ready to land.Oct 11 2022, 7:18 PM
gjb added a comment.Oct 11 2022, 7:18 PM

Thank you for the quick fix.

imp added a comment.Oct 11 2022, 7:19 PM
In D36941#839018, @gjb wrote:

Thank you for the quick fix.

It helped that I saw the email and had two thoughts "hey, I know how to fix that" and "WTF was I on when I wrote the code not to know that"

Closed by commit rG1be88beabb3c: release: link from /boot/msdos to efi (authored by imp). · Explain WhyOct 11 2022, 7:20 PM
This revision was automatically updated to reflect the committed changes.
imp added a commit: rG1be88beabb3c: release: link from /boot/msdos to efi.
gjb added a comment.EditedOct 11 2022, 7:23 PM

Hmm. I'm actually wondering if it should be

ln -s /boot/efi ${DESTDIR}/boot/msdos

I think as-is, this will create a link from /efi. Or am I overthinking/overlooking something?

markmi_dsl-only.net added a comment.Oct 11 2022, 7:29 PM

For:

ln -s efi ${DESTDIR}/boot/msdos

msdos points to efi in the same directory. No implicit / generation.

For:

ln -s /boot/efi ${DESTDIR}/boot/msdos

msdos points to /boot/efi .

Both ways reach the same file, as long as msdos is not moved to a different directory anyway.

gjb added a comment.Oct 11 2022, 7:48 PM
In D36941#839031, @markmi_dsl-only.net wrote:

For:

ln -s efi ${DESTDIR}/boot/msdos

msdos points to efi in the same directory. No implicit / generation.

For:

ln -s /boot/efi ${DESTDIR}/boot/msdos

msdos points to /boot/efi .

Both ways reach the same file, as long as msdos is not moved to a different directory anyway.

Thank you for the sanity check.

Revision Contents
Changeset List

PathSize
release/
tools/
2 lines

Diff 111657

View Options

release/tools/arm.subr

Loading...