Differential D36917

x11/libinput: Update to 1.21.0
ClosedPublic
Actions

Authored by manu on Oct 9 2022, 10:48 AM.

Tags

None

Referenced Files

	F82331875: D36917.diff
	Sat, Apr 27, 5:39 PM

	F82296059: D36917.id111635.diff
	Sat, Apr 27, 10:04 AM

	F82296058: D36917.id111591.diff
	Sat, Apr 27, 10:04 AM

	F82296049: D36917.id111985.diff
	Sat, Apr 27, 10:04 AM

	F82296047: D36917.id.diff
	Sat, Apr 27, 10:04 AM

	F82289522: D36917.diff
	Sat, Apr 27, 8:35 AM

	Unknown Object (File)
	Mon, Apr 22, 9:37 AM

	Unknown Object (File)
	Mar 9 2024, 2:52 AM

View All 38 Files

Subscribers

Details

Reviewers

None

Group Reviewers

Commits

R11:d56435624e27: x11/libinput: Update to 1.21.0

Summary

Release notes for 1.20: https://lists.x.org/archives/wayland-devel/2022-February/042111.html
Release notes for 1.21: https://gitlab.freedesktop.org/libinput/libinput/-/releases/1.21.0

Diff Detail

Repository

rP FreeBSD ports repository

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 47773
Build 44660: arc lint + arc unit

Event Timeline

manu created this revision.Oct 9 2022, 10:48 AM

Herald added a subscriber: mat. · View Herald TranscriptOct 9 2022, 10:48 AM

manu requested review of this revision.Oct 9 2022, 10:48 AM

manu added a reviewer: x11.Oct 9 2022, 10:49 AM

Harbormaster completed remote builds in B47754: Diff 111591.Oct 9 2022, 10:49 AM

diizzy added a subscriber: diizzy.Oct 10 2022, 3:11 AM

diizzy added inline comments.

x11/libinput/Makefile
3–4	Both variants are generated on the fly but for consistency with the rest of the tree use USE_GITLAB instead https://docs.freebsd.org/en/books/porters-handbook/book/#makefile-master_sites-gitlab
28	We should define how we want to handle libwacom https://gitlab.freedesktop.org/libinput/libinput/-/blob/1.21.0/meson_options.txt#L9

manu added inline comments.Oct 10 2022, 2:15 PM

x11/libinput/Makefile
3–4	This isn't the same, USE_GITLAB needs a commit and will download generated archive, I want to dl the published archives from the release section.
28	Unrelated with this review.

diizzy added inline comments.Oct 10 2022, 10:06 PM

x11/libinput/Makefile
3–4	There's no published archive, they are generated on the fly. If you want a published archive (release archive) they need to be attached such as here: https://gitlab.com/sane-project/backends/-/releases/1.1.1 otherwise you should follow Porters Handbook
28	I apologize, this is handled as a menu option in the port already.

Address @diizzy's comment.

Harbormaster completed remote builds in B47773: Diff 111635.Oct 11 2022, 9:05 AM

This revision was not accepted when it landed; it landed in state Needs Review.Oct 19 2022, 1:29 PM

Closed by commit R11:d56435624e27: x11/libinput: Update to 1.21.0 (authored by manu). · Explain Why

This revision was automatically updated to reflect the committed changes.

manu added a commit: R11:d56435624e27: x11/libinput: Update to 1.21.0.

Revision Contents
Changeset List

Path

Size

x11/

libinput/

10 lines

6 lines

13 lines

Diff 111635

x11/libinput/Makefile

Loading...

x11/libinput/distinfo

Loading...

x11/libinput/pkg-plist

Loading...