Differential D36816

rpc.lockd: Explicitly cast enum nlm_stats values to enum nlm4_stats.
ClosedPublic
Actions

Authored by jhb on Sep 29 2022, 10:29 PM.

Tags

None

Referenced Files

	F140791816: D36816.diff
	Sun, Dec 28, 2:30 AM

	Unknown Object (File)
	Nov 16 2025, 10:56 AM

	Unknown Object (File)
	Nov 16 2025, 7:20 AM

	Unknown Object (File)
	Oct 30 2025, 7:31 PM

	Unknown Object (File)
	Oct 28 2025, 1:18 AM

	Unknown Object (File)
	Oct 21 2025, 11:20 PM

	Unknown Object (File)
	Oct 10 2025, 1:18 AM

	Unknown Object (File)
	Oct 10 2025, 1:18 AM

View All 87 Files

Subscribers

Details

Reviewers

Commits

rG598fbd36f1ef: rpc.lockd: Explicitly cast enum nlm_stats values to enum nlm4_stats.
rG3b887005b4bb: rpc.lockd: Explicitly cast enum nlm_stats values to enum nlm4_stats.

Summary

NLM 4 status values are a superset of the older NLM protocol so these
casts are safe while pacifying -Wenum-conversion warnings from GCC.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 47630
Build 44517: arc lint + arc unit

Event Timeline

jhb created this revision.Sep 29 2022, 10:29 PM

Herald added a subscriber: imp. · View Herald TranscriptSep 29 2022, 10:29 PM

jhb requested review of this revision.Sep 29 2022, 10:29 PM

Harbormaster completed remote builds in B47630: Diff 111234.Sep 29 2022, 10:29 PM

Looks fine to me, rick

This revision is now accepted and ready to land.Sep 30 2022, 2:02 PM

Closed by commit rG3b887005b4bb: rpc.lockd: Explicitly cast enum nlm_stats values to enum nlm4_stats. (authored by jhb). · Explain WhyOct 3 2022, 11:13 PM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rG3b887005b4bb: rpc.lockd: Explicitly cast enum nlm_stats values to enum nlm4_stats..

jhb added a commit: rG598fbd36f1ef: rpc.lockd: Explicitly cast enum nlm_stats values to enum nlm4_stats..Nov 11 2022, 6:38 PM

Revision Contents
Changeset List

Path

Size

usr.sbin/

rpc.lockd/

12 lines

Diff 111234

usr.sbin/rpc.lockd/lock_proc.c

Loading...