Differential D36810

tail: Fix misleading indentation in ARG() macro.
ClosedPublic
Actions

Authored by jhb on Sep 29 2022, 10:24 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, Mar 13, 3:12 PM

	Unknown Object (File)
	Thu, Feb 27, 5:56 PM

	Unknown Object (File)
	Fri, Feb 21, 10:34 AM

	Unknown Object (File)
	Jan 17 2025, 4:09 PM

	Unknown Object (File)
	Jan 11 2025, 5:04 PM

	Unknown Object (File)
	Dec 28 2024, 3:25 PM

	Unknown Object (File)
	Nov 29 2024, 5:48 PM

	Unknown Object (File)
	Nov 20 2024, 3:24 PM

View All 38 Files

Subscribers

Details

Reviewers

emaste
imp

Commits

rGcf668c16974c: tail: Fix misleading indentation in ARG() macro.
rGc2e561a38f73: tail: Fix misleading indentation in ARG() macro.

Summary

Reported by: GCC

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 47624
Build 44511: arc lint + arc unit

Event Timeline

jhb created this revision.Sep 29 2022, 10:24 PM

Herald added a subscriber: imp. · View Herald TranscriptSep 29 2022, 10:24 PM

jhb requested review of this revision.Sep 29 2022, 10:24 PM

Harbormaster completed remote builds in B47624: Diff 111227.Sep 29 2022, 10:24 PM

emaste accepted this revision.Sep 30 2022, 2:30 PM

This revision is now accepted and ready to land.Sep 30 2022, 2:30 PM

imp accepted this revision.Sep 30 2022, 3:09 PM

Closed by commit rGc2e561a38f73: tail: Fix misleading indentation in ARG() macro. (authored by jhb). · Explain WhyOct 3 2022, 11:13 PM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rGc2e561a38f73: tail: Fix misleading indentation in ARG() macro..

jhb added a commit: rGcf668c16974c: tail: Fix misleading indentation in ARG() macro..Nov 11 2022, 6:38 PM

Revision Contents
Changeset List

Path

Size

usr.bin/

tail/

2 lines

Diff 111227

usr.bin/tail/tail.c

	Show First 20 Lines • Show All 112 Lines • ▼ Show 20 Lines		#define ARG(units, forward, backward) { \
	if (expand_number(optarg, &off)) \			if (expand_number(optarg, &off)) \
	err(1, "illegal offset -- %s", optarg); \			err(1, "illegal offset -- %s", optarg); \
	if (off > INT64_MAX / units \|\| off < INT64_MIN / units ) \			if (off > INT64_MAX / units \|\| off < INT64_MIN / units ) \
	errx(1, "illegal offset -- %s", optarg); \			errx(1, "illegal offset -- %s", optarg); \
	switch(optarg[0]) { \			switch(optarg[0]) { \
	case '+': \			case '+': \
	if (off) \			if (off) \
	off -= (units); \			off -= (units); \
	style = (forward); \			style = (forward); \
	break; \			break; \
	case '-': \			case '-': \
	off = -off; \			off = -off; \
	/* FALLTHROUGH */ \			/* FALLTHROUGH */ \
	default: \			default: \
	style = (backward); \			style = (backward); \
	break; \			break; \
	} \			} \
	▲ Show 20 Lines • Show All 252 Lines • Show Last 20 Lines