Page MenuHomeFreeBSD
Differential D36750

Fix various places which cast a pointer to a vm_paddr_t or vice versa.
ClosedPublic
Actions

Authored by jhb on Sep 27 2022, 5:34 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Dec 13, 9:19 PM
Unknown Object (File)
Sat, Nov 29, 3:05 AM
Unknown Object (File)
Fri, Nov 28, 8:32 PM
Unknown Object (File)
Tue, Nov 25, 9:57 PM
Unknown Object (File)
Sat, Nov 22, 9:28 PM
Unknown Object (File)
Nov 17 2025, 5:30 AM
Unknown Object (File)
Nov 17 2025, 2:44 AM
Unknown Object (File)
Nov 17 2025, 2:36 AM
View All 95 Files
Subscribers
imp

Details

Reviewers
markj
imp
Commits
rG32560694f776: Fix various places which cast a pointer to a vm_paddr_t or vice versa.
rGa9fca3b987bc: Fix various places which cast a pointer to a vm_paddr_t or vice versa.
Summary

GCC warns about the mismatched sizes on i386 where vm_paddr_t is 64
bits.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 47619
Build 44506: arc lint + arc unit

Event Timeline

jhb created this revision.Sep 27 2022, 5:34 PM
Herald added subscribers: ehem_freebsd_m5p.com, imp. · View Herald TranscriptSep 27 2022, 5:34 PM
jhb requested review of this revision.Sep 27 2022, 5:34 PM
Harbormaster completed remote builds in B47565: Diff 111090.Sep 27 2022, 5:34 PM
imp accepted this revision.Sep 27 2022, 6:22 PM
This revision is now accepted and ready to land.Sep 27 2022, 6:22 PM
markj added inline comments.Sep 27 2022, 6:30 PM
sys/x86/xen/hvm.c
200

I suspect this is supposed to be (vm_paddr_t)((uintptr_t)&hypercall_page - KERNBASE).

jhb updated this revision to Diff 111222.Sep 29 2022, 10:11 PM

Adjust Xen expression.

This revision now requires review to proceed.Sep 29 2022, 10:11 PM
Harbormaster completed remote builds in B47619: Diff 111222.Sep 29 2022, 10:11 PM
ehem_freebsd_m5p.com removed a subscriber: ehem_freebsd_m5p.com.Sep 30 2022, 1:27 AM
markj accepted this revision.Sep 30 2022, 2:20 PM
This revision is now accepted and ready to land.Sep 30 2022, 2:20 PM
imp accepted this revision.Sep 30 2022, 2:52 PM
Closed by commit rGa9fca3b987bc: Fix various places which cast a pointer to a vm_paddr_t or vice versa. (authored by jhb). · Explain WhyOct 3 2022, 11:12 PM
This revision was automatically updated to reflect the committed changes.
jhb added a commit: rGa9fca3b987bc: Fix various places which cast a pointer to a vm_paddr_t or vice versa..
jhb added a commit: rG32560694f776: Fix various places which cast a pointer to a vm_paddr_t or vice versa..Nov 11 2022, 6:38 PM

Revision Contents
Changeset List

PathSize
sys/
dev/
dcons/
2 lines
fb/
4 lines
vm/
2 lines
x86/
xen/
2 lines

Diff 111222

View Options

sys/dev/dcons/dcons_os.c

Loading...
View Options

sys/dev/fb/fbd.c

Loading...
View Options

sys/vm/vm_dumpset.h

Loading...
View Options

sys/x86/xen/hvm.c

Loading...