zlib crc32: Add prototypes for recently-added static functions.
ClosedPublic
Actions

Authored by jhb on Sep 27 2022, 5:42 PM.

Details

Reviewers

emaste
imp

Commits

rG2b4453ad8f84: zlib crc32: Add prototypes for recently-added static functions.
rG7550e242ab4c: zlib crc32: Add prototypes for recently-added static functions.

Summary

This appeases -Wstrict-prototypes with GCC. Using a separate
prototype using the OF macro seems to be consistent with the rest of
this file which still supports pre-ANSI C.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 47570
Build 44457: arc lint + arc unit

Event Timeline

jhb requested review of this revision.Sep 27 2022, 5:42 PM

jhb created this revision.

Harbormaster completed remote builds in B47570: Diff 111097.Sep 27 2022, 5:43 PM

Should these also be upstreamed?

This revision is now accepted and ready to land.Sep 27 2022, 6:17 PM

There's a bigger question of what to do w/ zlib upstream with K&R, so it seems fine to make this change in our tree now and separately try to tackle all of that together.

Closed by commit rG7550e242ab4c: zlib crc32: Add prototypes for recently-added static functions. (authored by jhb). · Explain WhySep 28 2022, 9:07 PM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rG7550e242ab4c: zlib crc32: Add prototypes for recently-added static functions..

jhb added a commit: rG2b4453ad8f84: zlib crc32: Add prototypes for recently-added static functions..Nov 11 2022, 6:37 PM