Page MenuHomeFreeBSD

vtblk: Requeue inside vtblk_request_execute
ClosedPublic

Authored by cperciva on Sep 22 2022, 7:00 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Aug 25, 7:19 PM
Unknown Object (File)
Fri, Aug 21, 12:56 PM
Unknown Object (File)
Thu, Aug 20, 1:39 PM
Unknown Object (File)
Sat, Aug 15, 1:01 AM
Unknown Object (File)
Wed, Aug 12, 5:21 PM
Unknown Object (File)
Sat, Aug 8, 5:36 PM
Unknown Object (File)
Jul 29 2026, 8:25 PM
Unknown Object (File)
Jul 28 2026, 11:52 AM
Subscribers

Details

Summary

Most virtio_blk requests are launched from vtblk_startio; prior to this
commit, if vtblk_request_execute failed (e.g. due to a lack of space on
the virtio queue) vtblk_startio would requeue the request to be
reattempted later.

Add a flag "vbr_requeue_on_error" to requests and perform the requeuing
from inside vtblk_request_execute instead.

No functional change intended.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 47486
Build 44373: arc lint + arc unit

Event Timeline

This revision is now accepted and ready to land.Oct 3 2022, 3:19 AM
imp added inline comments.
sys/dev/virtio/block/virtio_blk.c
1139

One can quibble over whether we should transition to bool for these, but the driver already has a few in the old-style.

This revision was automatically updated to reflect the committed changes.