Page MenuHomeFreeBSD
Differential D36662

audio/spotify-player: Move CARGO_CRATES list to Makefile.crates
ClosedPublic
Actions

Authored by jrm on Sep 21 2022, 10:34 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Aug 19, 5:24 PM
Unknown Object (File)
Tue, Aug 18, 8:41 PM
Unknown Object (File)
Tue, Aug 18, 8:35 PM
Unknown Object (File)
Tue, Aug 18, 1:12 PM
Unknown Object (File)
Tue, Aug 18, 1:12 PM
Unknown Object (File)
Tue, Aug 18, 1:11 PM
Unknown Object (File)
Tue, Aug 18, 10:55 AM
Unknown Object (File)
Tue, Aug 18, 10:55 AM
View All Files
Subscribers
eduardo
mat

Details

Reviewers
jfree
Commits
R11:2119296169cb: audio/spotify-player: Move CARGO_CRATES list to Makefile.crates
Summary

Mk/Uses/cargo.mk looks for Makefile.crates in MASTERDIR, so move the
list of CARGO_CRATES there to have a smaller and cleaner Makefile
and to make updates easier with

make cargo-crates > Makefile.crates.

Reported by: eduardo
Approved by: jfree (maintainer)
Sponsored by: The FreeBSD Foundation

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 47481
Build 44368: arc lint + arc unit

Event Timeline

jrm created this revision.Sep 21 2022, 10:34 PM
Herald added a subscriber: mat. · View Herald TranscriptSep 21 2022, 10:34 PM
jrm requested review of this revision.Sep 21 2022, 10:34 PM
Harbormaster completed remote builds in B47481: Diff 110830.Sep 21 2022, 10:34 PM
jfree added a comment.Sep 21 2022, 11:52 PM

Looks good to me. Great solution to clear up the primary Makefile.

This revision was not accepted when it landed; it landed in state Needs Review.Sep 22 2022, 12:05 AM
Closed by commit R11:2119296169cb: audio/spotify-player: Move CARGO_CRATES list to Makefile.crates (authored by jrm). · Explain Why
This revision was automatically updated to reflect the committed changes.
jrm added a commit: R11:2119296169cb: audio/spotify-player: Move CARGO_CRATES list to Makefile.crates.

Revision Contents
Changeset List

PathSize
audio/
spotify-player/
458 lines
57 lines

Diff 110830

View Options

audio/spotify-player/Makefile

Loading...
View Options

audio/spotify-player/Makefile.crates

Loading...