Page MenuHomeFreeBSD
Differential D36609

intr: add interrupt FOREACH macro
AbandonedPublic
Actions

Authored by ehem_freebsd_m5p.com on Sep 16 2022, 7:17 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Nov 1, 2:23 PM
Unknown Object (File)
Tue, Oct 22, 1:30 AM
Unknown Object (File)
Mon, Oct 21, 6:02 PM
Unknown Object (File)
Wed, Oct 16, 1:16 PM
Unknown Object (File)
Oct 2 2024, 8:11 PM
Unknown Object (File)
Sep 27 2024, 7:25 AM
Unknown Object (File)
Sep 26 2024, 11:29 AM
Unknown Object (File)
Sep 14 2024, 3:25 PM
View All 46 Files
Subscribers
imp
jhibbits
Contributor Reviews (src)

Details

Reviewers
None
Summary

Another thing sometimes needed, looping over all interrupts. This
iterates over all allocated interrupt numbers.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 47437
Build 44324: arc lint + arc unit

Event Timeline

ehem_freebsd_m5p.com created this revision.Sep 16 2022, 7:17 PM
Herald added subscribers: jhibbits, imp. · View Herald TranscriptSep 16 2022, 7:17 PM
ehem_freebsd_m5p.com requested review of this revision.Sep 16 2022, 7:17 PM
Harbormaster completed remote builds in B47431: Diff 110661.Sep 16 2022, 7:17 PM
ehem_freebsd_m5p.com added a parent revision: D32504: kern/intr: remove "irq" from kernel event API.Sep 16 2022, 7:18 PM
ehem_freebsd_m5p.com mentioned this in D36610: kern/intr: implement intrcnt/intrnames sysctl from event counters.Sep 16 2022, 7:31 PM
ehem_freebsd_m5p.com added a comment.Sep 16 2022, 7:43 PM

Hmm, then I spot the error...

ehem_freebsd_m5p.com updated this revision to Diff 110667.Sep 16 2022, 8:09 PM

Ick, dropping the idea of a common maximum possible interrupt number variable. Had seemed worthwhile, but now I'm unsure.

Harbormaster completed remote builds in B47437: Diff 110667.Sep 16 2022, 8:09 PM
ehem_freebsd_m5p.com added a subscriber: Contributor Reviews (src).Sep 20 2022, 4:37 AM

While at it, appears Herald rule H67 has been broken by the configuration change for arc (defaults to rG, not rS).

ehem_freebsd_m5p.com updated this revision to Diff 110871.Sep 23 2022, 1:56 AM

Naturally finding bugs during full build...

Harbormaster completed remote builds in B47499: Diff 110871.Sep 23 2022, 1:56 AM
ehem_freebsd_m5p.com added a comment.Sep 29 2022, 1:54 AM

This doesn't do much more than provide some support for D36610. I'm unsure of the approach, but needed something to maintain compatibility with D36610. I won't be surprised by abandoning this if a better approach is suggested.

ehem_freebsd_m5p.com abandoned this revision.Dec 24 2022, 8:02 PM

The need would be addressed by D37870. Since that is simpler and likely less controversial, go with that.

ehem_freebsd_m5p.com removed a parent revision: D32504: kern/intr: remove "irq" from kernel event API.May 10 2023, 1:52 AM

Revision Contents
Changeset List

PathSize
sys/
powerpc/
include/
7 lines
powerpc/
9 lines
sys/
8 lines
x86/
include/
8 lines

Diff 110667

View Options

sys/powerpc/include/intr.h

Loading...
View Options

sys/powerpc/powerpc/intr_machdep.c

Loading...
View Options

sys/sys/intr.h

Loading...
View Options

sys/x86/include/intr.h

Loading...