Page MenuHomeFreeBSD
Differential D36514

graphics/mesa-dri: Improve qsort_r detection.
ClosedPublic
Actions

Authored by delphij on Sep 10 2022, 8:36 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Nov 21, 1:49 PM
Unknown Object (File)
Fri, Nov 21, 1:46 PM
Unknown Object (File)
Fri, Nov 21, 1:44 PM
Unknown Object (File)
Fri, Nov 21, 1:35 PM
Unknown Object (File)
Wed, Nov 5, 10:00 PM
Unknown Object (File)
Wed, Nov 5, 12:44 PM
Unknown Object (File)
Wed, Nov 5, 6:19 AM
Unknown Object (File)
Wed, Nov 5, 5:42 AM
View All Files
Subscribers
mat

Details

Reviewers
manu
Group Reviewers
x11
Commits
R11:1b1270010864: graphics/mesa-dri: Improve qsort_r detection.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 47316
Build 44203: arc lint + arc unit

Event Timeline

delphij created this revision.Sep 10 2022, 8:36 AM
Herald added a subscriber: mat. · View Herald TranscriptSep 10 2022, 8:36 AM
delphij requested review of this revision.Sep 10 2022, 8:36 AM
Harbormaster completed remote builds in B47316: Diff 110419.Sep 10 2022, 8:37 AM
delphij added a reviewer: x11.Sep 10 2022, 8:37 AM
manu added a comment.Sep 10 2022, 10:25 AM

That should be upstreamed first.
Thanks.

delphij added a comment.Sep 10 2022, 8:39 PM
In D36514#829266, @manu wrote:

That should be upstreamed first.
Thanks.

Yes, a slightly different version was upstreamed as https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18527

manu requested changes to this revision.Sep 26 2022, 10:21 AM

Can you use PATCH_SITES/PATCHFILES and use the upstreamed one ?
Thanks.

This revision now requires changes to proceed.Sep 26 2022, 10:21 AM
delphij added a comment.Sep 26 2022, 4:45 PM
In D36514#833446, @manu wrote:

Can you use PATCH_SITES/PATCHFILES and use the upstreamed one ?
Thanks.

Unfortunately, no, because the upstreamed patch was against their latest main which was diverged from this branch quite a bit...

manu accepted this revision.Sep 27 2022, 6:22 AM
In D36514#833668, @delphij wrote:
In D36514#833446, @manu wrote:

Can you use PATCH_SITES/PATCHFILES and use the upstreamed one ?
Thanks.

Unfortunately, no, because the upstreamed patch was against their latest main which was diverged from this branch quite a bit...

Ok, too bad, feel free to commit this then and I handle this when I update mesa.

This revision is now accepted and ready to land.Sep 27 2022, 6:22 AM
Closed by commit R11:1b1270010864: graphics/mesa-dri: Improve qsort_r detection. (authored by delphij). · Explain WhySep 28 2022, 5:01 AM
This revision was automatically updated to reflect the committed changes.
delphij added a commit: R11:1b1270010864: graphics/mesa-dri: Improve qsort_r detection..

Revision Contents
Changeset List

PathSize
graphics/
mesa-dri/
files/
46 lines
26 lines

Diff 110419

View Options

graphics/mesa-dri/files/patch-meson.build

Loading...
View Options

graphics/mesa-dri/files/patch-src_util_u__qsort.h

Loading...