Page MenuHomeFreeBSD

Enable repeated line compression for lines of any length.
ClosedPublic

Authored by asomers on Dec 9 2015, 5:38 PM.
Tags
None
Referenced Files
F82163166: D4475.id10990.diff
Fri, Apr 26, 2:25 AM
F82163146: D4475.id.diff
Fri, Apr 26, 2:24 AM
F82158475: D4475.id12763.diff
Fri, Apr 26, 1:15 AM
Unknown Object (File)
Thu, Apr 25, 6:30 PM
Unknown Object (File)
Mon, Apr 8, 1:32 AM
Unknown Object (File)
Mar 1 2024, 6:57 AM
Unknown Object (File)
Dec 23 2023, 8:04 AM
Unknown Object (File)
Nov 15 2023, 3:38 PM
Subscribers

Details

Summary

Enable repeated line compression for lines of any length, instead of only short
lines. AFAICT repeated line compression was limited to short lines as a RAM
optimization, which made sense when karels added it in 1988, but no longer.
The penalty is a paltry 904B of RAM per file logged.

Test Plan

for i in jot 5 1; do
logger log a really loooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooong line
done

Verify that the line only shows up once in /var/log/messages

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 1530
Build 1536: arc lint + arc unit

Event Timeline

asomers retitled this revision from to Enable repeated line compression for lines of any length..
asomers updated this object.
asomers edited the test plan for this revision. (Show Details)
asomers added a reviewer: rpaulo.

Ping. Have you had a chance to review this change?

Ping. Are you ok with this change?

rpaulo edited edge metadata.

Please ping me by email directly next time.

This revision is now accepted and ready to land.Jan 27 2016, 6:14 AM
This revision was automatically updated to reflect the committed changes.