riscv: Add da9063_pmic and da9063_rtc to GENERIC and NOTES
ClosedPublic
Actions

Authored by jrtc27 on Aug 14 2022, 5:34 PM.

Details

Reviewers

mhorne
imp

Group Reviewers

riscv

Commits

rG2bf3e27a5785: riscv: Add da9063_pmic and da9063_rtc to GENERIC and NOTES
rG100f79569dbc: riscv: Add da9063_pmic and da9063_rtc to GENERIC and NOTES

Summary

This is the PMIC on SiFive's HiFive Unmatched; add it and the RTC child
device driver so we have a working RTC.

MFC after: 1 week

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 47060
Build 43949: arc lint + arc unit

Event Timeline

jrtc27 created this revision.Aug 14 2022, 5:34 PM

Herald added a subscriber: imp. · View Herald TranscriptAug 14 2022, 5:34 PM

jrtc27 requested review of this revision.Aug 14 2022, 5:34 PM

Harbormaster completed remote builds in B46940: Diff 109336.Aug 14 2022, 5:34 PM

jrtc27 added a parent revision: D36200: da9063_rtc: Add new driver for the Dialog Semiconductor DA9063 RTC.Aug 14 2022, 5:34 PM

I'd prefer if you called it da9063_pm instead of the named name da9063. It's generally preferable that device class names end in a letter.
Though maybe it's already that way in the tree

In D36201#821947, @imp wrote:

I'd prefer if you called it da9063_pm instead of the named name da9063. It's generally preferable that device class names end in a letter.
Though maybe it's already that way in the tree

D36199 is the revision for that; I can easily rename it to da9063_pmic.

mhorne accepted this revision.Aug 18 2022, 9:28 PM

This revision is now accepted and ready to land.Aug 18 2022, 9:28 PM

Renamed da9063 to da9063_pmic

This revision now requires review to proceed.Aug 22 2022, 7:27 PM

Harbormaster completed remote builds in B47060: Diff 109683.Aug 22 2022, 7:27 PM

jrtc27 retitled this revision from riscv: Add da9063 and da9063_rtc to GENERIC and NOTES to riscv: Add da9063_pmic and da9063_rtc to GENERIC and NOTES.Aug 22 2022, 7:28 PM

imp accepted this revision.Aug 22 2022, 10:03 PM

This revision is now accepted and ready to land.Aug 22 2022, 10:03 PM

mhorne accepted this revision.Sep 13 2022, 4:43 PM

Closed by commit rG100f79569dbc: riscv: Add da9063_pmic and da9063_rtc to GENERIC and NOTES (authored by jrtc27). · Explain WhySep 13 2022, 4:47 PM

This revision was automatically updated to reflect the committed changes.

jrtc27 added a commit: rG100f79569dbc: riscv: Add da9063_pmic and da9063_rtc to GENERIC and NOTES.

jrtc27 added a commit: rG2bf3e27a5785: riscv: Add da9063_pmic and da9063_rtc to GENERIC and NOTES.Aug 1 2023, 9:07 PM