Page MenuHomeFreeBSD
Differential D36150

virtio_mmio: Improve V1 spec conformance
ClosedPublic
Actions

Authored by bryanv on Aug 12 2022, 3:20 AM.
Tags
None
Referenced Files
F154127163: D36150.id.diff
Sun, Apr 26, 9:33 AM
Unknown Object (File)
Sat, Apr 25, 7:04 AM
Unknown Object (File)
Fri, Apr 24, 4:29 PM
Unknown Object (File)
Thu, Apr 23, 10:28 PM
Unknown Object (File)
Fri, Apr 17, 3:46 AM
Unknown Object (File)
Thu, Apr 16, 4:56 PM
Unknown Object (File)
Thu, Apr 16, 2:16 PM
Unknown Object (File)
Wed, Apr 15, 8:06 PM
View All Files
Subscribers
imp

Details

Reviewers
cperciva
Commits
rG926cedd9a071: virtio_mmio: Improve V1 spec conformance
Summary

Implement the virtio_bus_finalize_features method so the FEATURES_OK
status bit is set. Implement the virtio_bus_config_generation method
to ensure larger than 4-byte reads are consistent.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 46873
Build 43762: arc lint + arc unit

Event Timeline

bryanv created this revision.Aug 12 2022, 3:20 AM
Herald added a subscriber: imp. · View Herald TranscriptAug 12 2022, 3:20 AM
bryanv requested review of this revision.Aug 12 2022, 3:20 AM
Harbormaster completed remote builds in B46873: Diff 109214.Aug 12 2022, 3:20 AM
cperciva added inline comments.Aug 12 2022, 4:20 PM
sys/dev/virtio/mmio/virtio_mmio.c
470

I think we need to call this from vtmmio_reinit after the call to vtmmio_negotiate_features?

bryanv marked an inline comment as done.Aug 12 2022, 4:39 PM
bryanv added inline comments.
sys/dev/virtio/mmio/virtio_mmio.c
470

Yes thanks.

bryanv updated this revision to Diff 109254.Aug 12 2022, 4:39 PM
bryanv marked an inline comment as done.

Address comment

Harbormaster completed remote builds in B46902: Diff 109254.Aug 12 2022, 4:39 PM
cperciva accepted this revision.Aug 12 2022, 4:48 PM

Just tested, works with Firecracker.

This revision is now accepted and ready to land.Aug 12 2022, 4:48 PM
Closed by commit rG926cedd9a071: virtio_mmio: Improve V1 spec conformance (authored by bryanv). · Explain WhyAug 17 2022, 8:16 PM
This revision was automatically updated to reflect the committed changes.
bryanv added a commit: rG926cedd9a071: virtio_mmio: Improve V1 spec conformance.

Revision Contents
Changeset List

PathSize
sys/
dev/
virtio/
mmio/
78 lines

Diff 109214

View Options

sys/dev/virtio/mmio/virtio_mmio.c

Loading...