Page MenuHomeFreeBSD
Differential D4428

- Add DKIM support
ClosedPublic
Actions

Authored by miwi on Dec 7 2015, 2:45 PM.
Tags
None
Referenced Files
Unknown Object (File)
Jan 16 2026, 2:41 PM
Unknown Object (File)
Jan 9 2026, 5:29 AM
Unknown Object (File)
Dec 31 2025, 6:46 AM
Unknown Object (File)
Dec 19 2025, 6:00 AM
Unknown Object (File)
Dec 11 2025, 1:56 AM
Unknown Object (File)
Nov 30 2025, 3:01 PM
Unknown Object (File)
Nov 28 2025, 5:04 AM
Unknown Object (File)
Nov 26 2025, 2:23 PM
View All Files
Subscribers
None

Details

Reviewers
bapt
mat
Commits
rP404330: - Add DKIM support
Summary
  • Convert to options helpers

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 1470
Build 1475: arc lint + arc unit

Event Timeline

miwi updated this revision to Diff 10879.Dec 7 2015, 2:45 PM
miwi retitled this revision from to - Add DKIM support.
miwi updated this object.
miwi edited the test plan for this revision. (Show Details)
miwi added reviewers: mat, bapt.
mat added inline comments.Dec 7 2015, 3:26 PM
mail/milter-greylist/Makefile
57–61

Why not convert those too to the options helpers ?

63–66

This could be converted too.

93–100

those should be options helpers too.

miwi updated this revision to Diff 11528.Dec 21 2015, 5:16 PM
  • Convert to options helper

Note:
Execpt LDAP, the configure script seems still buggy.

mat added inline comments.Dec 21 2015, 10:57 PM
mail/milter-greylist/Makefile
59–66

If LDAP_CONFIGURE_WITH does not work because of the --without- clause, only use LDAP_CONFIGURE_ON, it would work.

miwi added a comment.Dec 21 2015, 11:20 PM

Why would you want to have ldap default enabled on a private mail server? it *should* seriously per default off.

mat edited edge metadata.Dec 22 2015, 12:15 AM
In D4428#98408, @miwi wrote:

Why would you want to have ldap default enabled on a private mail server? it *should* seriously per default off.

sorry, what ?

miwi added a comment.Dec 22 2015, 12:19 AM

What I am trying to say is 95% of mail servers do not use LDAP, why should we enable it here as default?

mat added a comment.Dec 22 2015, 12:21 AM

I never talked about enabling it by default.

miwi added a comment.Dec 22 2015, 12:23 AM

Forget about it. I should not do such things when to I am to sleepy.. I'll fix it in a while

miwi updated this revision to Diff 11548.Dec 22 2015, 1:36 AM
miwi edited edge metadata.
  • Convert LDAP as well.

Sorry for that mess here ..

mat added inline comments.Dec 22 2015, 1:51 AM
mail/milter-greylist/Makefile
41–46

All these should be = and not +=

54

This can be =

66

So, that can be removed too.

miwi updated this revision to Diff 11550.Dec 22 2015, 1:56 AM
  • Remove + ..
mat added inline comments.Dec 22 2015, 12:39 PM
mail/milter-greylist/Makefile
66

Remove. This. ?

miwi updated this revision to Diff 11577.Dec 22 2015, 12:49 PM
  • Remove bsd.port.options.mk
mat accepted this revision.Dec 23 2015, 8:56 PM
mat edited edge metadata.
mat added inline comments.
mail/milter-greylist/Makefile
68–78

No need to do += here.

101

maybe an empty line before this.

This revision is now accepted and ready to land.Dec 23 2015, 8:56 PM
Closed by commit rP404330: - Add DKIM support (authored by miwi). · Explain WhyDec 23 2015, 11:36 PM
This revision was automatically updated to reflect the committed changes.
miwi mentioned this in rP404330: - Add DKIM support.

Revision Contents
Changeset List

PathSize
mail/
milter-greylist/
24 lines

Diff 10879

View Options

mail/milter-greylist/Makefile

Loading...