Page MenuHomeFreeBSD

- Add DKIM support
ClosedPublic

Authored by miwi on Dec 7 2015, 2:45 PM.
Tags
None
Referenced Files
Unknown Object (File)
Jan 16 2026, 2:41 PM
Unknown Object (File)
Jan 9 2026, 5:29 AM
Unknown Object (File)
Dec 31 2025, 6:46 AM
Unknown Object (File)
Dec 19 2025, 6:00 AM
Unknown Object (File)
Dec 11 2025, 1:56 AM
Unknown Object (File)
Nov 30 2025, 3:01 PM
Unknown Object (File)
Nov 28 2025, 5:04 AM
Unknown Object (File)
Nov 26 2025, 2:23 PM
Subscribers
None

Details

Summary
  • Convert to options helpers

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

miwi retitled this revision from to - Add DKIM support.
miwi updated this object.
miwi edited the test plan for this revision. (Show Details)
miwi added reviewers: mat, bapt.
mail/milter-greylist/Makefile
57–61 ↗(On Diff #10879)

Why not convert those too to the options helpers ?

63–66 ↗(On Diff #10879)

This could be converted too.

93–100 ↗(On Diff #10879)

those should be options helpers too.

  • Convert to options helper

Note:
Execpt LDAP, the configure script seems still buggy.

mail/milter-greylist/Makefile
62–64 ↗(On Diff #11528)

If LDAP_CONFIGURE_WITH does not work because of the --without- clause, only use LDAP_CONFIGURE_ON, it would work.

Why would you want to have ldap default enabled on a private mail server? it *should* seriously per default off.

In D4428#98408, @miwi wrote:

Why would you want to have ldap default enabled on a private mail server? it *should* seriously per default off.

sorry, what ?

What I am trying to say is 95% of mail servers do not use LDAP, why should we enable it here as default?

I never talked about enabling it by default.

Forget about it. I should not do such things when to I am to sleepy.. I'll fix it in a while

miwi edited edge metadata.
  • Convert LDAP as well.

Sorry for that mess here ..

mail/milter-greylist/Makefile
41–45 ↗(On Diff #11548)

All these should be = and not +=

58 ↗(On Diff #11548)

This can be =

61 ↗(On Diff #11548)

So, that can be removed too.

mail/milter-greylist/Makefile
61 ↗(On Diff #11550)

Remove. This. ?

  • Remove bsd.port.options.mk
mat edited edge metadata.
mat added inline comments.
mail/milter-greylist/Makefile
61–71 ↗(On Diff #11577)

No need to do += here.

91 ↗(On Diff #11577)

maybe an empty line before this.

This revision is now accepted and ready to land.Dec 23 2015, 8:56 PM
This revision was automatically updated to reflect the committed changes.