Differential D35836
sh: accept fc options grouped behind one '-' Authored by pstef on Jul 17 2022, 8:23 AM. Tags None Referenced Files
Subscribers
Details
As per Utility Syntax Guidelines, accept both forms: -l -n and -ln. To do that, anticipate the source string for the next option that will To simplify the check for not_fcnumber, slightly modify nextopt() to
Diff Detail
Event TimelineComment Actions I've made the mistake of assuming that the first token has to be an option, but of course fc -1 must work. Slightly change the strategy to fix the original issue and keep the not_fcnumber() check first as it was originally. Comment Actions This should have testcases.
Comment Actions Slightly change the approach: each not_fcnumber() check, keep consuming options until we need to jump to the next argptr.
Comment Actions @jilles is this patch in a good shape now? Or maybe we should convert sh to use getopt? Custom options parsing keeps surprising people, see PR265399 for a recent example. Comment Actions Yes.
The echo builtin is defined not to support standard options parsing, and changing that will lead to compatibility issues. In the particular case of echo, I don't think it's worth it since there is no obviously best solution so there will still be many bad surprises after a fix. As for builtins that support standard options parsing, some of them used to use getopt() from libc, but we standardized on nextopt() to reduce code duplication and code size. For example, the error messages from getopt() cannot be used because they are sent to stderr instead of a potentially redirected out2 from output.c, for example echo ".$(umask -\? 2>&1)." . | |||||||||||||||||||||||||||||||||||||||||||||||||||||||||