Page MenuHomeFreeBSD
Differential D35195

comms/opencbm-kmod: Remove unused DRIVER_MODULE devclass on recent main.
ClosedPublic
Actions

Authored by jhb on May 13 2022, 4:54 PM.
Tags
None
Referenced Files
F174189082: D35195.diff
Thu, Oct 1, 6:08 AM
Unknown Object (File)
Wed, Sep 2, 6:18 PM
Unknown Object (File)
Wed, Sep 2, 12:03 AM
Unknown Object (File)
Aug 30 2026, 7:25 PM
Unknown Object (File)
Aug 22 2026, 10:51 AM
Unknown Object (File)
Aug 13 2026, 5:04 AM
Unknown Object (File)
Aug 8 2026, 4:51 PM
Unknown Object (File)
Aug 7 2026, 12:23 PM
View All Files
Subscribers
mat

Details

Reviewers
zirias
Commits
R11:7175e1ab5ff1: comms/opencbm-kmod: Remove unused DRIVER_MODULE devclass on recent main.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 45565
Build 42453: arc lint + arc unit

Event Timeline

jhb created this revision.May 13 2022, 4:54 PM
Herald added a subscriber: mat. · View Herald TranscriptMay 13 2022, 4:54 PM
jhb requested review of this revision.May 13 2022, 4:54 PM
Harbormaster completed remote builds in B45565: Diff 105946.May 13 2022, 4:54 PM
jhb added a reviewer: zirias.May 13 2022, 4:54 PM
zirias accepted this revision.May 13 2022, 5:57 PM

Looks fine for now, trusting your word the version constant is correct, hehe. Should probably try to take this upstream (and then update the port) ;)

This revision is now accepted and ready to land.May 13 2022, 5:57 PM
jhb added a child revision: D35168: *DRIVER_MODULE*: Remove the compat shims to accept the devclass argument..May 17 2022, 10:05 PM
jhb added a comment.May 20 2022, 5:09 PM

Do you have a relationship with upstream to post the patch there?

Closed by commit R11:7175e1ab5ff1: comms/opencbm-kmod: Remove unused DRIVER_MODULE devclass on recent main. (authored by jhb). · Explain WhyMay 20 2022, 5:14 PM
This revision was automatically updated to reflect the committed changes.
jhb added a commit: R11:7175e1ab5ff1: comms/opencbm-kmod: Remove unused DRIVER_MODULE devclass on recent main..
zirias added a comment.May 21 2022, 7:12 AM
In D35195#799397, @jhb wrote:

Do you have a relationship with upstream to post the patch there?

Kind of, I originally ported the Linux driver to FreeBSD ;) So, I'll open a pull request soon.

zirias added a comment.Jul 11 2022, 7:04 PM

Patch just landed upstream: https://github.com/OpenCBM/OpenCBM/commit/6e438c1b32d39e5238f65246e192c89b22fdfd82 – sorry for the long delay.

Revision Contents
Changeset List

PathSize
comms/
opencbm/
files/
25 lines

Diff 105946

View Options

comms/opencbm/files/patch-opencbm_sys_freebsd_opencbm.c

Loading...