Page MenuHomeFreeBSD
Differential D35175

linux(4): Get rid of __WCLONE handling.
AbandonedPublic
Actions

Authored by dchagin on May 11 2022, 6:00 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Oct 2, 4:30 PM
Unknown Object (File)
Wed, Oct 1, 12:30 AM
Unknown Object (File)
Sun, Sep 28, 3:28 PM
Unknown Object (File)
Thu, Sep 25, 4:58 AM
Unknown Object (File)
Sun, Sep 21, 4:56 AM
Unknown Object (File)
Sat, Sep 20, 10:38 PM
Unknown Object (File)
Sat, Sep 20, 9:21 PM
Unknown Object (File)
Sat, Sep 20, 4:44 PM
View All Files
Subscribers
emaste
imp

Details

Reviewers
None
Group Reviewers
Linux Emulation
Summary

SInce 81338031 (switch linuxulator to use the native 1:1 threads)
_WALL, _WCLONE flags are broken due to the fact that (to Linux kernel)
no distinction between processes and threads - everything is runnable
task. This allows do a weird things like waiting for a thread status
change by wait() API, unlike FreeBSD where wait() is process intended
only.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 45534
Build 42422: arc lint + arc unit

Event Timeline

dchagin created this revision.May 11 2022, 6:00 PM
Herald added a subscriber: imp. · View Herald TranscriptMay 11 2022, 6:00 PM
dchagin requested review of this revision.May 11 2022, 6:00 PM
Harbormaster completed remote builds in B45532: Diff 105864.May 11 2022, 6:00 PM
dchagin added a reviewer: Linux Emulation.May 11 2022, 6:01 PM
dchagin changed the repository for this revision from rS FreeBSD src repository - subversion to rG FreeBSD src repository.
emaste added a subscriber: emaste.May 11 2022, 6:12 PM
emaste added inline comments.
sys/compat/linux/linux_misc.c
1002

case typo (SInce)

2760–2761

do you have a sense of how common __WCLONE use is in various Linux applications?
(of course if it's broken we shouldn't pretend to support it - I'm just curious)

dchagin added inline comments.May 11 2022, 6:28 PM
sys/compat/linux/linux_misc.c
2760–2761

I haven't seen, NPTL does not use _WCLONE, however illumos implemented it (I don't know the reason or bug)

dchagin updated this revision to Diff 105874.May 11 2022, 8:46 PM

comment fixed

Harbormaster completed remote builds in B45534: Diff 105874.May 11 2022, 8:46 PM
dchagin updated this revision to Diff 105908.May 12 2022, 8:37 PM

leave WLINUXCLONE define as libsysdecode mktables fails,
it uses $DSTDIR/include, not $SRCDIR to build.

Harbormaster completed remote builds in B45549: Diff 105908.May 12 2022, 8:37 PM
dchagin abandoned this revision.Jul 2 2023, 11:19 AM

Revision Contents
Changeset List

PathSize
sys/
compat/
linux/
14 lines
kern/
16 lines
sys/
5 lines

Diff 105874

View Options

sys/compat/linux/linux_misc.c

Loading...
View Options

sys/kern/kern_exit.c

Loading...
View Options

sys/sys/wait.h

Loading...