Page MenuHomeFreeBSD
Differential D35060

firewire: Initialize firewire_devclass in fw_modevent.
ClosedPublic
Actions

Authored by jhb on Apr 26 2022, 12:09 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Sep 7, 7:53 AM
Unknown Object (File)
Sun, Sep 6, 5:33 PM
Unknown Object (File)
Sun, Sep 6, 2:47 PM
Unknown Object (File)
Sun, Sep 6, 8:56 AM
Unknown Object (File)
Sat, Sep 5, 2:05 PM
Unknown Object (File)
Fri, Sep 4, 1:52 PM
Unknown Object (File)
Fri, Sep 4, 6:09 AM
Unknown Object (File)
Fri, Sep 4, 4:52 AM
View All Files
Subscribers
None

Details

Reviewers
imp
emaste
Commits
rGfa160738bd18: firewire: Initialize firewire_devclass in fw_modevent.
Summary

The use of devclass_get_softc() combined with cdev unit numbers is
probably not ideal (probably should be initializing si_drv1 when each
cdev is created instead), but it looks like a bit of a PITA to do, so
just initialize the devclass explicitly instead.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 45368
Build 42256: arc lint + arc unit

Event Timeline

jhb requested review of this revision.Apr 26 2022, 12:09 AM
jhb created this revision.
Harbormaster completed remote builds in B45368: Diff 105416.Apr 26 2022, 12:10 AM
emaste accepted this revision.Apr 27 2022, 7:10 PM

Is it time to look at deprecation plans for firewire?

This revision is now accepted and ready to land.Apr 27 2022, 7:10 PM
jhb added a comment.Apr 27 2022, 7:18 PM

I thought it was already deprecated which is why I didn't try to fix this "cleanly".

Closed by commit rGfa160738bd18: firewire: Initialize firewire_devclass in fw_modevent. (authored by jhb). · Explain WhyApr 27 2022, 7:26 PM
This revision was automatically updated to reflect the committed changes.
jhb added a commit: rGfa160738bd18: firewire: Initialize firewire_devclass in fw_modevent..

Revision Contents
Changeset List

PathSize
sys/
dev/
firewire/
4 lines

Diff 105416

View Options

sys/dev/firewire/firewire.c

Loading...