Page MenuHomeFreeBSD

firewire: Initialize firewire_devclass in fw_modevent.
ClosedPublic

Authored by jhb on Apr 26 2022, 12:09 AM.
Tags
None
Referenced Files
F163377799: D35060.id105487.diff
Wed, Jul 22, 4:14 PM
Unknown Object (File)
Tue, Jul 21, 4:04 PM
Unknown Object (File)
Sun, Jul 19, 7:46 PM
Unknown Object (File)
Wed, Jul 1, 8:17 PM
Unknown Object (File)
Jun 18 2026, 6:34 PM
Unknown Object (File)
Jun 18 2026, 10:28 AM
Unknown Object (File)
Jun 18 2026, 9:43 AM
Unknown Object (File)
May 6 2026, 2:44 AM
Subscribers
None

Details

Summary

The use of devclass_get_softc() combined with cdev unit numbers is
probably not ideal (probably should be initializing si_drv1 when each
cdev is created instead), but it looks like a bit of a PITA to do, so
just initialize the devclass explicitly instead.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 45368
Build 42256: arc lint + arc unit

Event Timeline

jhb requested review of this revision.Apr 26 2022, 12:09 AM
jhb created this revision.

Is it time to look at deprecation plans for firewire?

This revision is now accepted and ready to land.Apr 27 2022, 7:10 PM

I thought it was already deprecated which is why I didn't try to fix this "cleanly".