Page MenuHomeFreeBSD
Differential D35038

cam: Small reorg of ata xpt async code
ClosedPublic
Actions

Authored by imp on Apr 24 2022, 2:32 AM.
Tags
None
Referenced Files
F105369399: D35038.id105359.diff
Sun, Dec 15, 11:05 AM
F105321531: D35038.diff
Sat, Dec 14, 9:53 PM
Unknown Object (File)
Oct 18 2024, 11:43 PM
Unknown Object (File)
Oct 4 2024, 8:17 PM
Unknown Object (File)
Oct 1 2024, 1:19 PM
Unknown Object (File)
Sep 27 2024, 3:18 PM
Unknown Object (File)
Sep 23 2024, 7:18 PM
Unknown Object (File)
Sep 18 2024, 11:12 PM
View All 36 Files
Subscribers
None

Details

Reviewers
mav
Group Reviewers
cam
Commits
rG9d899bbcb788: cam: Small reorg of ata xpt async code
Summary

Use a switch rather than a nested if to simplify the async event
processing code. No functional changes intended.

Sponsored by: Netflix

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

imp created this revision.Apr 24 2022, 2:32 AM
Herald added a reviewer: cam. · View Herald TranscriptApr 24 2022, 2:32 AM
imp requested review of this revision.Apr 24 2022, 2:32 AM
Harbormaster completed remote builds in B45336: Diff 105359.Apr 24 2022, 2:33 AM
imp added a child revision: D35039: ada: Eliminate dead code.Apr 24 2022, 2:33 AM
imp added a reviewer: mav.Apr 24 2022, 2:36 AM
mav accepted this revision.Apr 25 2022, 3:01 PM
This revision is now accepted and ready to land.Apr 25 2022, 3:01 PM
Closed by commit rG9d899bbcb788: cam: Small reorg of ata xpt async code (authored by imp). · Explain WhyApr 25 2022, 6:55 PM
This revision was automatically updated to reflect the committed changes.
imp added a commit: rG9d899bbcb788: cam: Small reorg of ata xpt async code.
mav added a comment.Apr 25 2022, 9:10 PM

Are you going to do the same for SCSI to not diverge them?

imp added a comment.EditedApr 25 2022, 11:28 PM
In D35038#794530, @mav wrote:

Are you going to do the same for SCSI to not diverge them?

That's a good idea. I know that nvme did it with a case statement, but I didn't look closely at scsi. thanks for suggesting I do that.

It looks like the SCSI code does this already, except it always calls cam_perhip_async(), which may have been your comment on a different review. I think ATA and SCSI (and others) should do it the same.

Revision Contents
Changeset List

PathSize
sys/
cam/
ata/
72 lines

Diff 105406

View Options

sys/cam/ata/ata_xpt.c

Loading...