Page MenuHomeFreeBSD
Differential D34982

kdump: Decode cpuset_t.
ClosedPublic
Actions

Authored by dchagin on Apr 20 2022, 4:00 PM.
Tags
None
Referenced Files
F84090971: D34982.id105536.diff
Sun, May 19, 5:34 AM
Unknown Object (File)
Wed, May 15, 11:27 PM
Unknown Object (File)
Mon, May 13, 8:48 PM
Unknown Object (File)
Fri, May 10, 6:26 PM
Unknown Object (File)
Fri, May 3, 1:07 PM
Unknown Object (File)
Thu, May 2, 6:21 PM
Unknown Object (File)
Wed, Apr 24, 3:13 PM
Unknown Object (File)
Wed, Apr 24, 3:13 PM
View All 57 Files
Subscribers
imp

Details

Reviewers
jhb
Commits
rG6e2a3ed6a765: kdump: Decode cpuset_t.
rG586ed321068b: kdump: Decode cpuset_t.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 45253
Build 42141: arc lint + arc unit

Event Timeline

dchagin created this revision.Apr 20 2022, 4:00 PM
Herald added a subscriber: imp. · View Herald TranscriptApr 20 2022, 4:00 PM
dchagin requested review of this revision.Apr 20 2022, 4:00 PM
Harbormaster completed remote builds in B45253: Diff 105211.Apr 20 2022, 4:00 PM
dchagin added a reviewer: jhb.Apr 20 2022, 4:07 PM
dchagin changed the repository for this revision from rS FreeBSD src repository - subversion to rG FreeBSD src repository.
dchagin updated this revision to Diff 105436.Apr 26 2022, 3:56 PM

print only significant bits

Harbormaster completed remote builds in B45382: Diff 105436.Apr 26 2022, 3:56 PM
jhb added a comment.Apr 26 2022, 9:12 PM

Generally looks good to me.

sys/sys/ktrace.h
310

I would probably just call this ktrcpuset without the trailing _t.

dchagin added inline comments.Apr 27 2022, 10:17 AM
sys/sys/ktrace.h
310

no problem, I gave this naming based on the fact that struct cpuset and cpuset_t - are different entities. will fix, thanks

dchagin updated this revision to Diff 105536.Apr 28 2022, 6:11 PM

fixed, thank you

Harbormaster completed remote builds in B45420: Diff 105536.Apr 28 2022, 6:11 PM
dchagin updated this revision to Diff 105676.May 4 2022, 3:17 PM

Reflect D34849 changes.

Harbormaster completed remote builds in B45464: Diff 105676.May 4 2022, 3:17 PM
dchagin added a parent revision: D34849: Use Linux semantics for the thread affinity syscalls..May 4 2022, 3:19 PM
jhb accepted this revision.May 4 2022, 6:37 PM
jhb added inline comments.
sys/kern/kern_cpuset.c
1980
This revision is now accepted and ready to land.May 4 2022, 6:37 PM
Closed by commit rG586ed321068b: kdump: Decode cpuset_t. (authored by dchagin). · Explain WhyMay 11 2022, 7:41 AM
This revision was automatically updated to reflect the committed changes.
dchagin added a commit: rG586ed321068b: kdump: Decode cpuset_t..
dchagin added a commit: rG6e2a3ed6a765: kdump: Decode cpuset_t..Jun 17 2022, 7:45 PM

Revision Contents
Changeset List

PathSize
sys/
kern/
11 lines
sys/
2 lines
usr.bin/
kdump/
33 lines

Diff 105211

View Options

sys/kern/kern_cpuset.c

Loading...
View Options

sys/sys/ktrace.h

Loading...
View Options

usr.bin/kdump/kdump.c

Loading...