bmake: Only handle .POSIX: in the right place
AbandonedPublic
Actions

Authored by cperciva on Apr 18 2022, 9:34 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, Sep 8, 10:10 PM

	Unknown Object (File)
	Sat, Sep 6, 9:20 PM

	Unknown Object (File)
	Sat, Sep 6, 2:00 PM

	Unknown Object (File)
	Sat, Sep 6, 8:03 AM

	Unknown Object (File)
	Sat, Sep 6, 7:52 AM

	Unknown Object (File)
	Aug 8 2025, 5:46 PM

	Unknown Object (File)
	Jul 25 2025, 10:57 PM

	Unknown Object (File)
	Jun 6 2025, 7:18 AM

View All 25 Files

Subscribers

imp

Details

Reviewers

sjg

Summary

POSIX specifies that the .POSIX: target must be the first
non-comment line in a Makefile. The way we handle it, by including
posix.mk when we first see .POSIX:, will break if we handle it at
other places.

Keep track of whether we're at the start of the Makefile and ignore
.POSIX: if not.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 45215
Build 42103: arc lint + arc unit

Event Timeline

cperciva created this revision.Apr 18 2022, 9:34 PM

Herald added a subscriber: imp. · View Herald TranscriptApr 18 2022, 9:34 PM

cperciva requested review of this revision.Apr 18 2022, 9:34 PM

Harbormaster completed remote builds in B45215: Diff 105137.Apr 18 2022, 9:34 PM

Never mind, NetBSD already has a fix for this: https://github.com/NetBSD/src/commit/686b9d31508b5cf03b7362f4e2f8a28d78bef7d8

Revision Contents
Changeset List

Path

Size

contrib/

bmake/

parse.c

11 lines

Diff 105137

View Options

bmake: Only handle .POSIX: in the right placeAbandonedPublicActions