Page MenuHomeFreeBSD
Differential D34862

tzsetup(8): Refactoring
ClosedPublic
Actions

Authored by asiciliano on Apr 9 2022, 9:58 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Oct 10, 9:16 PM
Unknown Object (File)
Thu, Oct 2, 11:54 AM
Unknown Object (File)
Thu, Oct 2, 4:44 AM
Unknown Object (File)
Tue, Sep 30, 11:40 PM
Unknown Object (File)
Tue, Sep 30, 1:07 PM
Unknown Object (File)
Sep 20 2025, 11:10 AM
Unknown Object (File)
Sep 13 2025, 5:11 PM
Unknown Object (File)
Sep 3 2025, 10:55 AM
View All 85 Files
Subscribers
imp

Details

Reviewers
bapt
Commits
rG94cb21cda66b: tzsetup(8): Refactoring to delete dialog(3) code
Summary

Little refactoring to complete the conversion to bsddialog(3), not functional changes:

  • Delete: remaining code for autosizing using BSDDIALOG_AUTOSIZE.
  • Add: constants to delete magical numbers and avoiding unclear return values.
  • Delete: redundant 'conf.button.defaultno=false', performed by bsddialog_initconf()
  • Add: a new function message_zoneinfo_file() to merge features.
Test Plan

Not functional changes, just some constant and a trivial function.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

asiciliano created this revision.Apr 9 2022, 9:58 PM
Herald added a subscriber: imp. · View Herald TranscriptApr 9 2022, 9:58 PM
asiciliano requested review of this revision.Apr 9 2022, 9:58 PM
bapt accepted this revision.Apr 10 2022, 6:39 AM

other than a small remark, it looks good to me

usr.sbin/tzsetup/tzsetup.c
607

maybe add some parenthesis for libility ?

This revision is now accepted and ready to land.Apr 10 2022, 6:39 AM
asiciliano updated this revision to Diff 104838.Apr 10 2022, 12:36 PM
asiciliano marked an inline comment as done.
asiciliano retitled this revision from tzsetup(8): (little) Refactoring to tzsetup(8): Refactoring.
asiciliano edited the summary of this revision. (Show Details)
asiciliano edited the test plan for this revision. (Show Details)

Fixed, thanks!

This revision now requires review to proceed.Apr 10 2022, 12:36 PM
asiciliano added inline comments.Apr 10 2022, 12:36 PM
usr.sbin/tzsetup/tzsetup.c
607

fixed

bapt accepted this revision.Apr 11 2022, 6:51 AM
This revision is now accepted and ready to land.Apr 11 2022, 6:51 AM
Closed by commit rG94cb21cda66b: tzsetup(8): Refactoring to delete dialog(3) code (authored by asiciliano). · Explain WhyApr 11 2022, 10:39 PM
This revision was automatically updated to reflect the committed changes.
asiciliano added a commit: rG94cb21cda66b: tzsetup(8): Refactoring to delete dialog(3) code.

Revision Contents
Changeset List

PathSize
usr.sbin/
tzsetup/
141 lines

Diff 104838

View Options

usr.sbin/tzsetup/tzsetup.c

Loading...