Paths

Table of Contentst

Differential D4260

graphics/gtk-update-icon-cache: postpone cairo-xlib.pc check
ClosedPublic
Actions

Authored by jbeich on Nov 23 2015, 3:42 PM.

Tags

None

Referenced Files

	F103550002: D4260.id10451.diff
	Tue, Nov 26, 10:01 AM

	F103534412: D4260.diff
	Tue, Nov 26, 5:11 AM

	Unknown Object (File)
	Mon, Nov 25, 1:58 AM

	Unknown Object (File)
	Sun, Nov 24, 9:13 PM

	Unknown Object (File)
	Sun, Nov 24, 12:22 PM

	Unknown Object (File)
	Sun, Nov 24, 7:08 AM

	Unknown Object (File)
	Sat, Nov 23, 10:35 PM

	Unknown Object (File)
	Sat, Nov 23, 8:53 PM

Subscribers

rfyu28uyeg_snkmail.com

Details

Reviewers

None

Group Reviewers

Commits

rP402343: graphics/gtk-update-icon-cache: restore r297047 after r313633

Summary

Restore rP297047 accidentally reverted by rP313633. This ensures cairo is installed before the check is triggered. It also eliminates the need to use .include <bsd.port.pre.mk> to use ${LOCALBASE}.

Let's go a step further and invoke pkg-config as the port already has USES=pkgconfig and convert ${ECHO_CMD} to ${ECHO_MSG} per Porter's Handbook.

Test Plan

poudriere testport -P builds: 93i386, 93amd64, 101i386, 102amd64

Diff Detail

Repository

rP FreeBSD ports repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jbeich updated this revision to Diff 10451.Nov 23 2015, 3:42 PM

jbeich retitled this revision from to graphics/gtk-update-icon-cache: postpone cairo-xlib.pc check.

jbeich updated this object.

jbeich edited the test plan for this revision. (Show Details)

jbeich added a reviewer: gnome.

Looks good. Thanks, Jan.

That's ugly (my id which is my anti-spam email address). I wonder if phabricator has a setting to override that -- John Hein

This looks good, could you update gtk20 and gtk30 Makefile too with the same change? Thanks

Closed by commit rP402343: graphics/gtk-update-icon-cache: restore r297047 after r313633 (authored by jbeich). · Explain WhyNov 24 2015, 4:09 AM

This revision was automatically updated to reflect the committed changes.

In D4260#89837, @kwm wrote:

This looks good, could you update gtk20 and gtk30 Makefile too with the same change? Thanks

Done. gtk30 required one more nit before killing .include line: rP402344.

Revision Contents
Changeset List

Path

Size

head/

graphics/

gtk-update-icon-cache/

13 lines

x11-toolkits/

gtk20/

11 lines

gtk30/

10 lines

Diff 10459

head/graphics/gtk-update-icon-cache/Makefile

Loading...

head/x11-toolkits/gtk20/Makefile

Loading...

head/x11-toolkits/gtk30/Makefile

Loading...