Page MenuHomeFreeBSD
Differential D4260

graphics/gtk-update-icon-cache: postpone cairo-xlib.pc check
ClosedPublic
Actions

Authored by jbeich on Nov 23 2015, 3:42 PM.
Tags
None
Referenced Files
F166859694: D4260.id.diff
Mon, Aug 17, 5:30 AM
Unknown Object (File)
Sat, Aug 8, 2:49 PM
Unknown Object (File)
Sat, Aug 8, 10:21 AM
Unknown Object (File)
Sat, Aug 8, 8:50 AM
Unknown Object (File)
Mon, Aug 3, 5:03 AM
Unknown Object (File)
Mon, Aug 3, 4:18 AM
Unknown Object (File)
Sun, Aug 2, 7:35 PM
Unknown Object (File)
Sun, Aug 2, 5:18 AM
View All Files
Subscribers
kwm
rfyu28uyeg_snkmail.com

Details

Reviewers
None
Group Reviewers
gnome
Commits
rP402343: graphics/gtk-update-icon-cache: restore r297047 after r313633
Summary

Restore rP297047 accidentally reverted by rP313633. This ensures cairo is installed before the check is triggered. It also eliminates the need to use .include <bsd.port.pre.mk> to use ${LOCALBASE}.

Let's go a step further and invoke pkg-config as the port already has USES=pkgconfig and convert ${ECHO_CMD} to ${ECHO_MSG} per Porter's Handbook.

Test Plan

poudriere testport -P builds: 93i386, 93amd64, 101i386, 102amd64

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 1263
Build 1267: arc lint + arc unit

Event Timeline

jbeich updated this revision to Diff 10451.Nov 23 2015, 3:42 PM
jbeich retitled this revision from to graphics/gtk-update-icon-cache: postpone cairo-xlib.pc check.
jbeich updated this object.
jbeich edited the test plan for this revision. (Show Details)
jbeich added a reviewer: gnome.
rfyu28uyeg_snkmail.com added a subscriber: rfyu28uyeg_snkmail.com.Nov 23 2015, 7:13 PM

Looks good. Thanks, Jan.

rfyu28uyeg_snkmail.com added a comment.Nov 23 2015, 7:16 PM

That's ugly (my id which is my anti-spam email address). I wonder if phabricator has a setting to override that -- John Hein

kwm added a subscriber: kwm.Nov 23 2015, 9:50 PM

This looks good, could you update gtk20 and gtk30 Makefile too with the same change? Thanks

Closed by commit rP402343: graphics/gtk-update-icon-cache: restore r297047 after r313633 (authored by jbeich). · Explain WhyNov 24 2015, 4:09 AM
This revision was automatically updated to reflect the committed changes.
jbeich added a comment.Nov 24 2015, 4:13 AM
In D4260#89837, @kwm wrote:

This looks good, could you update gtk20 and gtk30 Makefile too with the same change? Thanks

Done. gtk30 required one more nit before killing .include line: rP402344.

Revision Contents
Changeset List

PathSize
graphics/
gtk-update-icon-cache/
13 lines

Diff 10451

View Options

graphics/gtk-update-icon-cache/Makefile

Loading...