Page MenuHomeFreeBSD

graphics/gtk-update-icon-cache: postpone cairo-xlib.pc check
ClosedPublic

Authored by jbeich on Nov 23 2015, 3:42 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Feb 19, 12:27 PM
Unknown Object (File)
Mon, Feb 19, 5:54 AM
Unknown Object (File)
Mon, Feb 19, 5:54 AM
Unknown Object (File)
Mon, Feb 19, 5:42 AM
Unknown Object (File)
Feb 16 2024, 1:56 AM
Unknown Object (File)
Jan 19 2024, 10:12 AM
Unknown Object (File)
Jan 10 2024, 10:37 AM
Unknown Object (File)
Dec 23 2023, 5:10 AM

Details

Summary

Restore rP297047 accidentally reverted by rP313633. This ensures cairo is installed before the check is triggered. It also eliminates the need to use .include <bsd.port.pre.mk> to use ${LOCALBASE}.

Let's go a step further and invoke pkg-config as the port already has USES=pkgconfig and convert ${ECHO_CMD} to ${ECHO_MSG} per Porter's Handbook.

Test Plan

poudriere testport -P builds: 93i386, 93amd64, 101i386, 102amd64

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jbeich retitled this revision from to graphics/gtk-update-icon-cache: postpone cairo-xlib.pc check.
jbeich updated this object.
jbeich edited the test plan for this revision. (Show Details)
jbeich added a reviewer: gnome.

That's ugly (my id which is my anti-spam email address). I wonder if phabricator has a setting to override that -- John Hein

This looks good, could you update gtk20 and gtk30 Makefile too with the same change? Thanks

This revision was automatically updated to reflect the committed changes.
In D4260#89837, @kwm wrote:

This looks good, could you update gtk20 and gtk30 Makefile too with the same change? Thanks

Done. gtk30 required one more nit before killing .include line: rP402344.