Page MenuHomeFreeBSD

net/qt5-network: fix with LibreSSL 3.5
ClosedPublic

Authored by vishwin on Mar 21 2022, 7:59 AM.
Tags
None
Referenced Files
F168239388: D34619.id.diff
Thu, Aug 27, 3:03 AM
Unknown Object (File)
Wed, Aug 26, 7:36 PM
Unknown Object (File)
Wed, Aug 26, 8:18 AM
Unknown Object (File)
Sun, Aug 23, 2:49 AM
Unknown Object (File)
Mon, Aug 17, 10:49 PM
Unknown Object (File)
Sat, Aug 8, 7:48 PM
Unknown Object (File)
Jul 28 2026, 4:23 PM
Unknown Object (File)
Jun 17 2026, 10:54 AM
Subscribers

Details

Summary

LibreSSL 3.5, currently security/libressl-devel, opaqued many structs and implemented more functions in line with OpenSSL 1.1

Test Plan

Consumers dogfooded, work as intended

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 44839
Build 41727: arc lint + arc unit

Event Timeline

net/qt5-network/files/patch-src_network_ssl_qsslsocket__openssl__symbols__p.h
107

please use parenthesis to make the precedence of || and && explicit.

net/qt5-network/files/patch-src_network_ssl_qsslsocket__openssl__symbols__p.h
107

Not sure how additional parentheses would help? There are enough of them as is, especially with the !defined(). Kinda sucks that in the latter bit we have to check whether the define exists (because OpenSSL does not define it) otherwise the preprocessor errors out.

net/qt5-network/files/patch-src_network_ssl_qsslsocket__openssl__symbols__p.h
107

Sorry, I missed that you already have them around the (defined(LIBRESSL)...) :)

Ship it as discussed in IRC.

This revision is now accepted and ready to land.May 25 2022, 6:47 PM
This revision now requires review to proceed.May 25 2022, 7:01 PM
This revision was not accepted when it landed; it landed in state Needs Review.May 25 2022, 7:06 PM
This revision was automatically updated to reflect the committed changes.