Page MenuHomeFreeBSD
Differential D34571

gpiopower: Fix failure case for attach
ClosedPublic
Actions

Authored by jhibbits on Mar 15 2022, 6:37 PM.
Tags
None
Referenced Files
F142648445: D34571.id.diff
Wed, Jan 21, 8:38 PM
Unknown Object (File)
Tue, Jan 20, 8:29 PM
Unknown Object (File)
Tue, Dec 30, 5:33 AM
Unknown Object (File)
Wed, Dec 24, 11:12 AM
Unknown Object (File)
Nov 1 2025, 10:27 PM
Unknown Object (File)
Oct 27 2025, 5:16 AM
Unknown Object (File)
Oct 16 2025, 3:47 PM
Unknown Object (File)
Oct 15 2025, 5:25 PM
View All 83 Files
Subscribers
imp
loos

Details

Reviewers
alfredo
Group Reviewers
PowerPC
Commits
rGd7661890efd2: gpiopower: Fix failure case for attach
Summary

We really should be checking the return value of
ofw_gpiobus_parse_gpios_impl, not the value of sc_pins, which isn't
changed on failure.

Reported by: alfredo@

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jhibbits created this revision.Mar 15 2022, 6:37 PM
Herald added subscribers: loos, imp. · View Herald TranscriptMar 15 2022, 6:37 PM
jhibbits requested review of this revision.Mar 15 2022, 6:37 PM
Harbormaster completed remote builds in B44786: Diff 103894.Mar 15 2022, 6:37 PM
alfredo accepted this revision.Mar 15 2022, 7:12 PM

LGTM. Thanks, it fixes the kernel crashing with QEMU -M ppce500.

This revision is now accepted and ready to land.Mar 15 2022, 7:12 PM
Closed by commit rGd7661890efd2: gpiopower: Fix failure case for attach (authored by jhibbits). · Explain WhyMar 16 2022, 12:11 AM
This revision was automatically updated to reflect the committed changes.
jhibbits added a commit: rGd7661890efd2: gpiopower: Fix failure case for attach.

Revision Contents
Changeset List

PathSize
sys/
dev/
gpio/
3 lines

Diff 103906

View Options

sys/dev/gpio/gpiopower.c

Loading...