who: add libxo support
Needs ReviewPublic
Actions

Authored by swills on Mar 12 2022, 8:51 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, Jul 19, 12:21 AM

	Unknown Object (File)
	Wed, Jul 15, 10:28 PM

	Unknown Object (File)
	Sun, Jul 12, 12:12 AM

	Unknown Object (File)
	Tue, Jul 7, 6:05 AM

	Unknown Object (File)
	Mon, Jun 29, 5:33 PM

	Unknown Object (File)
	Wed, Jun 24, 1:14 AM

	Unknown Object (File)
	Sun, Jun 21, 6:27 PM

	Unknown Object (File)
	Jun 16 2026, 3:51 AM

View All Files

Subscribers

jlduran

Details

Reviewers

kevans

Summary

Add libxo support to who(1)

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 44755
Build 41643: arc lint + arc unit

Event Timeline

swills requested review of this revision.Mar 12 2022, 8:51 PM

swills created this revision.

Harbormaster completed remote builds in B44755: Diff 103793.Mar 12 2022, 8:51 PM

Thanks, I appreciate it!

(I really need to learn how to use Phabricator 🙃). I'll start with the low hanging fruits, and let someone more knowledgeable handle I18n and more advanced stuff, if needed.

I have attached a file with a couple of minor nits:

Simple addition to the man page
Addressing the two line comments
Removing extra brackets for one-lined ìf statements for consistency with the rest of the file (not really necessary)

I would prefer if (xo_get_style(NULL) == XO_STYLE_TEXT) to if (xo_get_style(NULL) != XO_STYLE_TEXT) everywhere, but this is an old habit of avoiding inverted logic if possible (not really necessary).

D34541.diff6 KBDownload