Page MenuHomeFreeBSD
Differential D4208

Update password-store to 1.6.4
ClosedPublic
Actions

Authored by rene on Nov 19 2015, 6:08 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Apr 8, 5:38 PM
Unknown Object (File)
Fri, Apr 4, 9:50 PM
Unknown Object (File)
Mar 15 2025, 5:31 PM
Unknown Object (File)
Jan 31 2025, 7:52 PM
Unknown Object (File)
Jan 28 2025, 2:14 AM
Unknown Object (File)
Jan 27 2025, 3:08 AM
Unknown Object (File)
Jan 25 2025, 12:22 PM
Unknown Object (File)
Jan 23 2025, 9:01 PM
View All Files
Subscribers
rene

Details

Reviewers
swills
eadler
milki
Summary

Update password-store to 1.6.4

  • CONTRIB option installs completion files for bash, zsh, fish
  • No longer patches out git and xclip integration
Test Plan

http://poudriere.ircmylife.com:13780/data/latest-per-pkg/password-store/1.6.4/

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 1218
Build 1222: arc lint + arc unit

Event Timeline

milki updated this revision to Diff 10329.Nov 19 2015, 6:08 AM
milki retitled this revision from to Update password-store to 1.6.4.
milki updated this object.
milki edited the test plan for this revision. (Show Details)
milki added reviewers: swills, eadler.
milki updated this revision to Diff 10330.Nov 19 2015, 6:30 AM

Unmute install steps. Don't include gitignore.

milki updated this revision to Diff 10331.Nov 19 2015, 6:31 AM

Unconditionally include manpage

milki updated this revision to Diff 10332.Nov 19 2015, 7:11 AM

1.6.4 has an additional contrib file

eadler accepted this revision.Jan 31 2016, 4:15 AM
eadler edited edge metadata.
This revision is now accepted and ready to land.Jan 31 2016, 4:15 AM
rene commandeered this revision.May 31 2016, 10:29 AM
rene added a reviewer: milki.
rene added a subscriber: rene.

This port had its maintainer reset, I have taken over maintainership.

rene closed this revision.May 31 2016, 4:26 PM

Updated to 1.6.5 in r416209

Revision Contents
Changeset List

PathSize
sysutils/
password-store/
39 lines
4 lines
6 lines

Diff 10331

View Options

sysutils/password-store/Makefile

Show All 40 Lines
* *
* CRC32 code derived from work by Gary S. Brown. * CRC32 code derived from work by Gary S. Brown.
*/ */
#include <sys/cdefs.h> #include <sys/cdefs.h>
__FBSDID("$FreeBSD$"); __FBSDID("$FreeBSD$");
#include <sys/param.h> #include <sys/param.h>
#include <sys/libkern.h>
#include <sys/systm.h> #include <sys/systm.h>
#if defined(__amd64__) || defined(__i386__)
#include <machine/md_var.h>
#include <machine/specialreg.h>
#endif
const uint32_t crc32_tab[] = { const uint32_t crc32_tab[] = {
0x00000000, 0x77073096, 0xee0e612c, 0x990951ba, 0x076dc419, 0x706af48f, 0x00000000, 0x77073096, 0xee0e612c, 0x990951ba, 0x076dc419, 0x706af48f,
0xe963a535, 0x9e6495a3, 0x0edb8832, 0x79dcb8a4, 0xe0d5e91e, 0x97d2d988, 0xe963a535, 0x9e6495a3, 0x0edb8832, 0x79dcb8a4, 0xe0d5e91e, 0x97d2d988,
0x09b64c2b, 0x7eb17cbd, 0xe7b82d07, 0x90bf1d91, 0x1db71064, 0x6ab020f2, 0x09b64c2b, 0x7eb17cbd, 0xe7b82d07, 0x90bf1d91, 0x1db71064, 0x6ab020f2,
0xf3b97148, 0x84be41de, 0x1adad47d, 0x6ddde4eb, 0xf4d4b551, 0x83d385c7, 0xf3b97148, 0x84be41de, 0x1adad47d, 0x6ddde4eb, 0xf4d4b551, 0x83d385c7,
0x136c9856, 0x646ba8c0, 0xfd62f97a, 0x8a65c9ec, 0x14015c4f, 0x63066cd9, 0x136c9856, 0x646ba8c0, 0xfd62f97a, 0x8a65c9ec, 0x14015c4f, 0x63066cd9,
0xfa0f3d63, 0x8d080df5, 0x3b6e20c8, 0x4c69105e, 0xd56041e4, 0xa2677172, 0xfa0f3d63, 0x8d080df5, 0x3b6e20c8, 0x4c69105e, 0xd56041e4, 0xa2677172,
0x3c03e4d1, 0x4b04d447, 0xd20d85fd, 0xa50ab56b, 0x35b5a8fa, 0x42b2986c, 0x3c03e4d1, 0x4b04d447, 0xd20d85fd, 0xa50ab56b, 0x35b5a8fa, 0x42b2986c,
▲ Show 20 Lines • Show All 685 Lines • ▼ Show 20 Linesmultitable_crc32c(uint32_t crc32c,
return (crc32c_sb8_64_bit(crc32c, buffer, length, to_even_word)); return (crc32c_sb8_64_bit(crc32c, buffer, length, to_even_word));
} }
uint32_t uint32_t
calculate_crc32c(uint32_t crc32c, calculate_crc32c(uint32_t crc32c,
const unsigned char *buffer, const unsigned char *buffer,
unsigned int length) unsigned int length)
{ {
if (length < 4) { if (length < 4) {
jhbUnsubmitted
Not Done
Inline Actions

You can just use #ifdef __SSE4_2__. -msse42 (or -msse4) will define that via the compiler driver. That is what controls 'popcnt' (in the case of popcnt we use it if you set CPUTYPE in your make.conf to specify a CPU that includes popcnt).

jhb: You can just use `#ifdef __SSE4_2__`. -msse42 (or -msse4) will define that via the compiler…
cemAuthorUnsubmitted
Not Done
Inline Actions

Is -msse4 used to compile this file on i386/amd64? I thought it was off by default, and only enabled on a few files. My build logs actually show -mno-sse -mno-avx.

cem: Is `-msse4` used to compile this file on i386/amd64? I thought it was off by default, and only…
markjUnsubmitted
Not Done
Inline Actions

The entries in sys/conf/files.* explicitly specify -msse4.

markj: The entries in sys/conf/files.* explicitly specify -msse4.
cemAuthorUnsubmitted
Not Done
Inline Actions

Only for libkern/x86/crc32_sse42.c. Not libkern/crc32.c (this file).

cem: Only for libkern/x86/crc32_sse42.c. Not libkern/crc32.c (this file).
return (singletable_crc32c(crc32c, buffer, length)); return (singletable_crc32c(crc32c, buffer, length));
#if defined(__amd64__) || defined(__i386__)
kibUnsubmitted
Not Done
Inline Actions

Do we need defined(_KERNEL) there as well ? Why PC98 is excluded (it seems to be on the way out) ?

kib: Do we need defined(_KERNEL) there as well ? Why PC98 is excluded (it seems to be on the way…
cemAuthorUnsubmitted
Not Done
Inline Actions

Is this code built outside of _KERNEL? tinderbox succeeds, so I don't believe this code is used outside of the kernel.

PC98 is excluded because I believe it predates SSE4.2, and I preferred to avoid including dead SSE4.2 code in the PC98 kernel if it would never be used.

cem: Is this code built outside of _KERNEL? tinderbox succeeds, so I don't believe this code is…
} else if ((cpu_feature2 & CPUID2_SSE42) != 0) {
return (sse42_crc32c(crc32c, buffer, length));
#endif
} else { } else {
return (multitable_crc32c(crc32c, buffer, length)); return (multitable_crc32c(crc32c, buffer, length));
} }
} }
View Options

sysutils/password-store/distinfo

Show All 40 Lines
* *
* CRC32 code derived from work by Gary S. Brown. * CRC32 code derived from work by Gary S. Brown.
*/ */
#include <sys/cdefs.h> #include <sys/cdefs.h>
__FBSDID("$FreeBSD$"); __FBSDID("$FreeBSD$");
#include <sys/param.h> #include <sys/param.h>
#include <sys/libkern.h>
#include <sys/systm.h> #include <sys/systm.h>
#if defined(__amd64__) || defined(__i386__)
#include <machine/md_var.h>
#include <machine/specialreg.h>
#endif
const uint32_t crc32_tab[] = { const uint32_t crc32_tab[] = {
0x00000000, 0x77073096, 0xee0e612c, 0x990951ba, 0x076dc419, 0x706af48f, 0x00000000, 0x77073096, 0xee0e612c, 0x990951ba, 0x076dc419, 0x706af48f,
0xe963a535, 0x9e6495a3, 0x0edb8832, 0x79dcb8a4, 0xe0d5e91e, 0x97d2d988, 0xe963a535, 0x9e6495a3, 0x0edb8832, 0x79dcb8a4, 0xe0d5e91e, 0x97d2d988,
0x09b64c2b, 0x7eb17cbd, 0xe7b82d07, 0x90bf1d91, 0x1db71064, 0x6ab020f2, 0x09b64c2b, 0x7eb17cbd, 0xe7b82d07, 0x90bf1d91, 0x1db71064, 0x6ab020f2,
0xf3b97148, 0x84be41de, 0x1adad47d, 0x6ddde4eb, 0xf4d4b551, 0x83d385c7, 0xf3b97148, 0x84be41de, 0x1adad47d, 0x6ddde4eb, 0xf4d4b551, 0x83d385c7,
0x136c9856, 0x646ba8c0, 0xfd62f97a, 0x8a65c9ec, 0x14015c4f, 0x63066cd9, 0x136c9856, 0x646ba8c0, 0xfd62f97a, 0x8a65c9ec, 0x14015c4f, 0x63066cd9,
0xfa0f3d63, 0x8d080df5, 0x3b6e20c8, 0x4c69105e, 0xd56041e4, 0xa2677172, 0xfa0f3d63, 0x8d080df5, 0x3b6e20c8, 0x4c69105e, 0xd56041e4, 0xa2677172,
0x3c03e4d1, 0x4b04d447, 0xd20d85fd, 0xa50ab56b, 0x35b5a8fa, 0x42b2986c, 0x3c03e4d1, 0x4b04d447, 0xd20d85fd, 0xa50ab56b, 0x35b5a8fa, 0x42b2986c,
▲ Show 20 Lines • Show All 685 Lines • ▼ Show 20 Linesmultitable_crc32c(uint32_t crc32c,
return (crc32c_sb8_64_bit(crc32c, buffer, length, to_even_word)); return (crc32c_sb8_64_bit(crc32c, buffer, length, to_even_word));
} }
uint32_t uint32_t
calculate_crc32c(uint32_t crc32c, calculate_crc32c(uint32_t crc32c,
const unsigned char *buffer, const unsigned char *buffer,
unsigned int length) unsigned int length)
{ {
if (length < 4) { if (length < 4) {
jhbUnsubmitted
Not Done
Inline Actions

You can just use #ifdef __SSE4_2__. -msse42 (or -msse4) will define that via the compiler driver. That is what controls 'popcnt' (in the case of popcnt we use it if you set CPUTYPE in your make.conf to specify a CPU that includes popcnt).

jhb: You can just use `#ifdef __SSE4_2__`. -msse42 (or -msse4) will define that via the compiler…
cemAuthorUnsubmitted
Not Done
Inline Actions

Is -msse4 used to compile this file on i386/amd64? I thought it was off by default, and only enabled on a few files. My build logs actually show -mno-sse -mno-avx.

cem: Is `-msse4` used to compile this file on i386/amd64? I thought it was off by default, and only…
markjUnsubmitted
Not Done
Inline Actions

The entries in sys/conf/files.* explicitly specify -msse4.

markj: The entries in sys/conf/files.* explicitly specify -msse4.
cemAuthorUnsubmitted
Not Done
Inline Actions

Only for libkern/x86/crc32_sse42.c. Not libkern/crc32.c (this file).

cem: Only for libkern/x86/crc32_sse42.c. Not libkern/crc32.c (this file).
return (singletable_crc32c(crc32c, buffer, length)); return (singletable_crc32c(crc32c, buffer, length));
#if defined(__amd64__) || defined(__i386__)
kibUnsubmitted
Not Done
Inline Actions

Do we need defined(_KERNEL) there as well ? Why PC98 is excluded (it seems to be on the way out) ?

kib: Do we need defined(_KERNEL) there as well ? Why PC98 is excluded (it seems to be on the way…
cemAuthorUnsubmitted
Not Done
Inline Actions

Is this code built outside of _KERNEL? tinderbox succeeds, so I don't believe this code is used outside of the kernel.

PC98 is excluded because I believe it predates SSE4.2, and I preferred to avoid including dead SSE4.2 code in the PC98 kernel if it would never be used.

cem: Is this code built outside of _KERNEL? tinderbox succeeds, so I don't believe this code is…
} else if ((cpu_feature2 & CPUID2_SSE42) != 0) {
return (sse42_crc32c(crc32c, buffer, length));
#endif
} else { } else {
return (multitable_crc32c(crc32c, buffer, length)); return (multitable_crc32c(crc32c, buffer, length));
} }
} }
View Options

sysutils/password-store/files/

Show All 40 Lines
* *
* CRC32 code derived from work by Gary S. Brown. * CRC32 code derived from work by Gary S. Brown.
*/ */
#include <sys/cdefs.h> #include <sys/cdefs.h>
__FBSDID("$FreeBSD$"); __FBSDID("$FreeBSD$");
#include <sys/param.h> #include <sys/param.h>
#include <sys/libkern.h>
#include <sys/systm.h> #include <sys/systm.h>
#if defined(__amd64__) || defined(__i386__)
#include <machine/md_var.h>
#include <machine/specialreg.h>
#endif
const uint32_t crc32_tab[] = { const uint32_t crc32_tab[] = {
0x00000000, 0x77073096, 0xee0e612c, 0x990951ba, 0x076dc419, 0x706af48f, 0x00000000, 0x77073096, 0xee0e612c, 0x990951ba, 0x076dc419, 0x706af48f,
0xe963a535, 0x9e6495a3, 0x0edb8832, 0x79dcb8a4, 0xe0d5e91e, 0x97d2d988, 0xe963a535, 0x9e6495a3, 0x0edb8832, 0x79dcb8a4, 0xe0d5e91e, 0x97d2d988,
0x09b64c2b, 0x7eb17cbd, 0xe7b82d07, 0x90bf1d91, 0x1db71064, 0x6ab020f2, 0x09b64c2b, 0x7eb17cbd, 0xe7b82d07, 0x90bf1d91, 0x1db71064, 0x6ab020f2,
0xf3b97148, 0x84be41de, 0x1adad47d, 0x6ddde4eb, 0xf4d4b551, 0x83d385c7, 0xf3b97148, 0x84be41de, 0x1adad47d, 0x6ddde4eb, 0xf4d4b551, 0x83d385c7,
0x136c9856, 0x646ba8c0, 0xfd62f97a, 0x8a65c9ec, 0x14015c4f, 0x63066cd9, 0x136c9856, 0x646ba8c0, 0xfd62f97a, 0x8a65c9ec, 0x14015c4f, 0x63066cd9,
0xfa0f3d63, 0x8d080df5, 0x3b6e20c8, 0x4c69105e, 0xd56041e4, 0xa2677172, 0xfa0f3d63, 0x8d080df5, 0x3b6e20c8, 0x4c69105e, 0xd56041e4, 0xa2677172,
0x3c03e4d1, 0x4b04d447, 0xd20d85fd, 0xa50ab56b, 0x35b5a8fa, 0x42b2986c, 0x3c03e4d1, 0x4b04d447, 0xd20d85fd, 0xa50ab56b, 0x35b5a8fa, 0x42b2986c,
▲ Show 20 Lines • Show All 685 Lines • ▼ Show 20 Linesmultitable_crc32c(uint32_t crc32c,
return (crc32c_sb8_64_bit(crc32c, buffer, length, to_even_word)); return (crc32c_sb8_64_bit(crc32c, buffer, length, to_even_word));
} }
uint32_t uint32_t
calculate_crc32c(uint32_t crc32c, calculate_crc32c(uint32_t crc32c,
const unsigned char *buffer, const unsigned char *buffer,
unsigned int length) unsigned int length)
{ {
if (length < 4) { if (length < 4) {
jhbUnsubmitted
Not Done
Inline Actions

You can just use #ifdef __SSE4_2__. -msse42 (or -msse4) will define that via the compiler driver. That is what controls 'popcnt' (in the case of popcnt we use it if you set CPUTYPE in your make.conf to specify a CPU that includes popcnt).

jhb: You can just use `#ifdef __SSE4_2__`. -msse42 (or -msse4) will define that via the compiler…
cemAuthorUnsubmitted
Not Done
Inline Actions

Is -msse4 used to compile this file on i386/amd64? I thought it was off by default, and only enabled on a few files. My build logs actually show -mno-sse -mno-avx.

cem: Is `-msse4` used to compile this file on i386/amd64? I thought it was off by default, and only…
markjUnsubmitted
Not Done
Inline Actions

The entries in sys/conf/files.* explicitly specify -msse4.

markj: The entries in sys/conf/files.* explicitly specify -msse4.
cemAuthorUnsubmitted
Not Done
Inline Actions

Only for libkern/x86/crc32_sse42.c. Not libkern/crc32.c (this file).

cem: Only for libkern/x86/crc32_sse42.c. Not libkern/crc32.c (this file).
return (singletable_crc32c(crc32c, buffer, length)); return (singletable_crc32c(crc32c, buffer, length));
#if defined(__amd64__) || defined(__i386__)
kibUnsubmitted
Not Done
Inline Actions

Do we need defined(_KERNEL) there as well ? Why PC98 is excluded (it seems to be on the way out) ?

kib: Do we need defined(_KERNEL) there as well ? Why PC98 is excluded (it seems to be on the way…
cemAuthorUnsubmitted
Not Done
Inline Actions

Is this code built outside of _KERNEL? tinderbox succeeds, so I don't believe this code is used outside of the kernel.

PC98 is excluded because I believe it predates SSE4.2, and I preferred to avoid including dead SSE4.2 code in the PC98 kernel if it would never be used.

cem: Is this code built outside of _KERNEL? tinderbox succeeds, so I don't believe this code is…
} else if ((cpu_feature2 & CPUID2_SSE42) != 0) {
return (sse42_crc32c(crc32c, buffer, length));
#endif
} else { } else {
return (multitable_crc32c(crc32c, buffer, length)); return (multitable_crc32c(crc32c, buffer, length));
} }
} }
View Options

sysutils/password-store/files/git+xclip.patch

Show All 40 Lines
* *
* CRC32 code derived from work by Gary S. Brown. * CRC32 code derived from work by Gary S. Brown.
*/ */
#include <sys/cdefs.h> #include <sys/cdefs.h>
__FBSDID("$FreeBSD$"); __FBSDID("$FreeBSD$");
#include <sys/param.h> #include <sys/param.h>
#include <sys/libkern.h>
#include <sys/systm.h> #include <sys/systm.h>
#if defined(__amd64__) || defined(__i386__)
#include <machine/md_var.h>
#include <machine/specialreg.h>
#endif
const uint32_t crc32_tab[] = { const uint32_t crc32_tab[] = {
0x00000000, 0x77073096, 0xee0e612c, 0x990951ba, 0x076dc419, 0x706af48f, 0x00000000, 0x77073096, 0xee0e612c, 0x990951ba, 0x076dc419, 0x706af48f,
0xe963a535, 0x9e6495a3, 0x0edb8832, 0x79dcb8a4, 0xe0d5e91e, 0x97d2d988, 0xe963a535, 0x9e6495a3, 0x0edb8832, 0x79dcb8a4, 0xe0d5e91e, 0x97d2d988,
0x09b64c2b, 0x7eb17cbd, 0xe7b82d07, 0x90bf1d91, 0x1db71064, 0x6ab020f2, 0x09b64c2b, 0x7eb17cbd, 0xe7b82d07, 0x90bf1d91, 0x1db71064, 0x6ab020f2,
0xf3b97148, 0x84be41de, 0x1adad47d, 0x6ddde4eb, 0xf4d4b551, 0x83d385c7, 0xf3b97148, 0x84be41de, 0x1adad47d, 0x6ddde4eb, 0xf4d4b551, 0x83d385c7,
0x136c9856, 0x646ba8c0, 0xfd62f97a, 0x8a65c9ec, 0x14015c4f, 0x63066cd9, 0x136c9856, 0x646ba8c0, 0xfd62f97a, 0x8a65c9ec, 0x14015c4f, 0x63066cd9,
0xfa0f3d63, 0x8d080df5, 0x3b6e20c8, 0x4c69105e, 0xd56041e4, 0xa2677172, 0xfa0f3d63, 0x8d080df5, 0x3b6e20c8, 0x4c69105e, 0xd56041e4, 0xa2677172,
0x3c03e4d1, 0x4b04d447, 0xd20d85fd, 0xa50ab56b, 0x35b5a8fa, 0x42b2986c, 0x3c03e4d1, 0x4b04d447, 0xd20d85fd, 0xa50ab56b, 0x35b5a8fa, 0x42b2986c,
▲ Show 20 Lines • Show All 685 Lines • ▼ Show 20 Linesmultitable_crc32c(uint32_t crc32c,
return (crc32c_sb8_64_bit(crc32c, buffer, length, to_even_word)); return (crc32c_sb8_64_bit(crc32c, buffer, length, to_even_word));
} }
uint32_t uint32_t
calculate_crc32c(uint32_t crc32c, calculate_crc32c(uint32_t crc32c,
const unsigned char *buffer, const unsigned char *buffer,
unsigned int length) unsigned int length)
{ {
if (length < 4) { if (length < 4) {
jhbUnsubmitted
Not Done
Inline Actions

You can just use #ifdef __SSE4_2__. -msse42 (or -msse4) will define that via the compiler driver. That is what controls 'popcnt' (in the case of popcnt we use it if you set CPUTYPE in your make.conf to specify a CPU that includes popcnt).

jhb: You can just use `#ifdef __SSE4_2__`. -msse42 (or -msse4) will define that via the compiler…
cemAuthorUnsubmitted
Not Done
Inline Actions

Is -msse4 used to compile this file on i386/amd64? I thought it was off by default, and only enabled on a few files. My build logs actually show -mno-sse -mno-avx.

cem: Is `-msse4` used to compile this file on i386/amd64? I thought it was off by default, and only…
markjUnsubmitted
Not Done
Inline Actions

The entries in sys/conf/files.* explicitly specify -msse4.

markj: The entries in sys/conf/files.* explicitly specify -msse4.
cemAuthorUnsubmitted
Not Done
Inline Actions

Only for libkern/x86/crc32_sse42.c. Not libkern/crc32.c (this file).

cem: Only for libkern/x86/crc32_sse42.c. Not libkern/crc32.c (this file).
return (singletable_crc32c(crc32c, buffer, length)); return (singletable_crc32c(crc32c, buffer, length));
#if defined(__amd64__) || defined(__i386__)
kibUnsubmitted
Not Done
Inline Actions

Do we need defined(_KERNEL) there as well ? Why PC98 is excluded (it seems to be on the way out) ?

kib: Do we need defined(_KERNEL) there as well ? Why PC98 is excluded (it seems to be on the way…
cemAuthorUnsubmitted
Not Done
Inline Actions

Is this code built outside of _KERNEL? tinderbox succeeds, so I don't believe this code is used outside of the kernel.

PC98 is excluded because I believe it predates SSE4.2, and I preferred to avoid including dead SSE4.2 code in the PC98 kernel if it would never be used.

cem: Is this code built outside of _KERNEL? tinderbox succeeds, so I don't believe this code is…
} else if ((cpu_feature2 & CPUID2_SSE42) != 0) {
return (sse42_crc32c(crc32c, buffer, length));
#endif
} else { } else {
return (multitable_crc32c(crc32c, buffer, length)); return (multitable_crc32c(crc32c, buffer, length));
} }
} }
View Options

sysutils/password-store/files/git.patch

Loading...
View Options

sysutils/password-store/files/xclip.patch

Loading...
View Options

sysutils/password-store/pkg-plist

Loading...