Differential D34315

powerpc: enable initial-exec TLS
ClosedPublic
Actions

Authored by pkubaj on Feb 18 2022, 1:24 PM.

Tags

None

Referenced Files

	F166947479: D34315.id103116.diff
	Tue, Aug 18, 12:37 AM

	Unknown Object (File)
	Mon, Aug 10, 4:20 AM

	Unknown Object (File)
	Sat, Aug 8, 4:48 PM

	Unknown Object (File)
	Thu, Aug 6, 11:12 PM

	Unknown Object (File)
	Wed, Aug 5, 4:42 PM

	Unknown Object (File)
	Tue, Aug 4, 3:14 AM

	Unknown Object (File)
	Sat, Aug 1, 7:56 AM

	Unknown Object (File)
	Sat, Aug 1, 5:19 AM

Subscribers

Contributor Reviews (src)

Details

Reviewers

Group Reviewers

Commits

rG137f2548ad71: powerpc: enable initial-exec TLS
rG884ba43116d4: powerpc: enable initial-exec TLS

Summary

Use initial-exec, like other architectures.

While here, switch MACHINE_ARCH in lib/libc/Makefile to LIBC_ARCH and consistently use powerpc.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 44495
Build 41383: arc lint + arc unit

Event Timeline

pkubaj created this revision.Feb 18 2022, 1:24 PM

Herald added subscribers: Contributor Reviews (src), imp. · View Herald TranscriptFeb 18 2022, 1:24 PM

pkubaj requested review of this revision.Feb 18 2022, 1:24 PM

Harbormaster completed remote builds in B44495: Diff 102930.Feb 18 2022, 1:24 PM

pkubaj added a reviewer: PowerPC.Feb 18 2022, 1:25 PM

luporl accepted this revision.Feb 22 2022, 5:06 PM

This revision is now accepted and ready to land.Feb 22 2022, 5:06 PM

emaste added a subscriber: emaste.Feb 22 2022, 5:16 PM

emaste added inline comments.

lib/libc/Makefile
35	Is this just for consistency? I should add a comment explaining this conditional - I wondered where this came from, and was surprised to find I added it in 0f61170882cb39a3fa4b76bcfc9c8acd2404a2da :) I will do that after your commit though.

pkubaj added inline comments.Feb 22 2022, 6:28 PM

lib/libc/Makefile
35	Yes, since it's only for consistency and doesn't actually change anything.

Closed by commit rG884ba43116d4: powerpc: enable initial-exec TLS (authored by pkubaj). · Explain WhyFeb 22 2022, 6:35 PM

This revision was automatically updated to reflect the committed changes.

pkubaj added a commit: rG884ba43116d4: powerpc: enable initial-exec TLS.

pkubaj added a commit: rG137f2548ad71: powerpc: enable initial-exec TLS.Mar 8 2022, 12:29 AM

Revision Contents
Changeset List

Path

Size

contrib/

jemalloc/

include/

jemalloc/

jemalloc_FreeBSD.h

2 lines

lib/

libc/

7 lines

Diff 102930

contrib/jemalloc/include/jemalloc/jemalloc_FreeBSD.h

Loading...

lib/libc/Makefile

Loading...