security/py-letsencrypt: Update to version 20151114
ClosedPublic
Actions

Authored by brnrd on Nov 15 2015, 10:34 AM.

Details

Reviewers

cpm
koobs

Summary

Proposed commit log:

security/py-letsencrypt: Update to version 20151114

  - Update py-letsencrypt and py-acme (to v0.0.0dev20151114)
  - Add regression test target for py-acme

Changes:

  - Turn off old/insecure challenge types[1]

[1]: https://community.letsencrypt.org/t/turning-off-old-insecure-challenge-types/3825

Reviewed by: koobs (mentor)
Approved by: koobs (mentor, maintainer)
DifferentialRevision:	https://reviews.freebsd.org/D4162

Test Plan

portlint -AC

py-acme:
WARN: Makefile: for new port, make $FreeBSD$ tag in comment section empty, to make SVN happy.
0 fatal errors and 1 warning found.
py-letsencrypt:
looks fine.

poudriere testport py-acme, py-letsencrypt
regression test py-acme{F287222}, py-letsencrypt{F287223}

Diff Detail

Repository

rP FreeBSD ports repository

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 1152
Build 1156: arc lint + arc unit

Event Timeline

brnrd updated this revision to Diff 10188.Nov 15 2015, 10:34 AM

brnrd retitled this revision from to security/py-letsencrypt: Update to version 20151114.

brnrd updated this object.

brnrd edited the test plan for this revision. (Show Details)

brnrd added reviewers: koobs, cpm.

brnrd added a subscriber: feld.

brnrd updated this object.Nov 15 2015, 10:35 AM

brnrd edited the test plan for this revision. (Show Details)Nov 15 2015, 10:42 AM

brnrd edited the test plan for this revision. (Show Details)

Unit test results?

In your proposed commit logs, separate 'software' changes with 'port' changes

Eg:

  * Update py-letsencrypt and py-acme (dependency)
  * Turning off old/insecure challenge types[1]

[1]: https://community.letsencrypt.org/t/turning-off-old-insecure-challenge-types/3825

becomes

- Update py-letsencrypt and py-acme (to 0.0.0.dev20151114)

Changes:

 - Turning off old/insecure challenge types [1]

[1]: https://community.letsencrypt.org/t/turning-off-old-insecure-challenge-types/3825

Also, since this is a developer preview, enumerating the changes in the port commit log is not really necessary
Also be consistent with your bullet point characters (- vs *, i prefer the former)
Also be consistent with indenting

In D4162#87507, @koobs wrote:

- Update py-letsencrypt and py-acme (to 0.0.0.dev20151114)

Changes:

 - Turning off old/insecure challenge types [1]

[1]: https://community.letsencrypt.org/t/turning-off-old-insecure-challenge-types/3825

Noted

Also, since this is a developer preview, enumerating the changes in the port commit log is not really necessary

Also be consistent with your bullet point characters (- vs *, i prefer the former)

"-"from now on

Also be consistent with indenting

Not sure which indenting you're referring to here. Alignment of the meta-data values?

Add test target to py-acme

brnrd updated this object.Nov 15 2015, 5:55 PM

brnrd edited the test plan for this revision. (Show Details)Nov 15 2015, 5:58 PM

Also, since this is a developer preview, enumerating the changes in the port commit log is not really necessary

Keep in mind that we have two weeks before it's open to the world. We should really get this committed and merged to quarterly sooner than later.

@brnrd What is the output of make test for py-letsencrypt? - Please add to TEST PLAN section

In D4162#88330, @koobs wrote:

@brnrd What is the output of make test for py-letsencrypt? - Please add to TEST PLAN section

The make test output is already attached to the Test Plan section!

LGTM, pending approval from py-acme maintainer (@cpm_fbsd.es)

This revision is now accepted and ready to land.Nov 18 2015, 11:40 AM

In D4162#88347, @koobs wrote:

LGTM, pending approval from py-acme maintainer (@cpm_fbsd.es)

Go ahead, Kubilay :)

In D4162#88844, @cpm_fbsd.es wrote:

In D4162#88347, @koobs wrote:

LGTM, pending approval from py-acme maintainer (@cpm_fbsd.es)

Go ahead, Kubilay :)