Differential D34023

libthr: Use TLS_TCB_* in _tcb_[cd]tor.
ClosedPublic
Actions

Authored by jhb on Jan 25 2022, 12:24 AM.

Details

Reviewers

kib

Commits

rGc4ec1f6efb52: libthr: Use TLS_TCB_* in _tcb_[cd]tor.
rG8de1a8131e42: libthr: Use TLS_TCB_* in _tcb_[cd]tor.

Summary

This matches libc and rtld in using the alignment (TLS_TCB_ALIGN) from
machine/tls.h instead of hardcoding 16.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 44077
Build 40965: arc lint + arc unit

Event Timeline

jhb created this revision.Jan 25 2022, 12:24 AM

Herald added a subscriber: imp. · View Herald TranscriptJan 25 2022, 12:24 AM

jhb requested review of this revision.Jan 25 2022, 12:24 AM

Harbormaster completed remote builds in B44077: Diff 101866.Jan 25 2022, 12:24 AM

I missed this in my earlier machine/tls.h changes. I only changed the size argument to be consistent with rtld/libc that use TLS_TCB_SIZE.

I believe this is fine, although it indeed changes the alignment.

This revision is now accepted and ready to land.Jan 25 2022, 12:37 AM

Closed by commit rG8de1a8131e42: libthr: Use TLS_TCB_* in _tcb_[cd]tor. (authored by jhb). · Explain WhyJan 25 2022, 7:40 PM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rG8de1a8131e42: libthr: Use TLS_TCB_* in _tcb_[cd]tor..

jhb added a commit: rGc4ec1f6efb52: libthr: Use TLS_TCB_* in _tcb_[cd]tor..Apr 29 2022, 11:13 PM

Revision Contents
Changeset List

Path

Size

lib/

libthr/

thread/

thr_ctrdtr.c

4 lines

Diff 101866

View Options

lib/libthr/thread/thr_ctrdtr.c

libthr: Use TLS_TCB_* in _tcb_[cd]tor.ClosedPublicActions