Page MenuHomeFreeBSD

framework: add hook to detect whether new ports are hooked into the tree
ClosedPublic

Authored by tcberner on Jan 24 2022, 7:58 PM.
Tags
None
Referenced Files
F87517523: D34015.id101846.diff
Thu, Jul 4, 8:16 AM
F87515524: D34015.id104948.diff
Thu, Jul 4, 7:34 AM
Unknown Object (File)
Tue, Jul 2, 11:01 PM
Unknown Object (File)
Tue, Jul 2, 6:33 AM
Unknown Object (File)
Sun, Jun 30, 7:19 PM
Unknown Object (File)
Thu, Jun 27, 12:19 AM
Unknown Object (File)
Thu, Jun 27, 12:17 AM
Unknown Object (File)
Sat, Jun 22, 4:40 PM
Subscribers

Details

Summary

This pre-commit hook looks for newly added files matching
foo/bar/Makefile
For these files, it is checking that a SUBDIR+=bar entry is
present in foo/Makefile.

This is likely not yet all-there, and should/could probably be
extended to also make sure that foo/Makefile is staged too, and
also handle port removals...

Example run output:

	> mkdir -p graphics/test_port
	> touch graphics/test_port/Makefile
	> git add graphics/test_port/Makefile
	> git commit -m "[new port] graphics/test_port: antoine will send you a mail"
	[pre-commit] ERROR: Missing 'SUBDIR += test_port' in graphics/Makefile

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 44066
Build 40954: arc lint + arc unit