Differential D33957

fusefs: Address -Wunused-but-set-variable warnings
ClosedPublic
Actions

Authored by markj on Jan 19 2022, 10:49 PM.

Tags

None

Referenced Files

	F105756734: D33957.diff
	Fri, Dec 20, 5:50 AM

	Unknown Object (File)
	Mon, Dec 9, 2:16 PM

	Unknown Object (File)
	Tue, Dec 3, 9:47 PM

	Unknown Object (File)
	Nov 8 2024, 4:04 AM

	Unknown Object (File)
	Oct 22 2024, 7:46 AM

	Unknown Object (File)
	Oct 3 2024, 4:49 AM

	Unknown Object (File)
	Oct 1 2024, 10:19 AM

	Unknown Object (File)
	Sep 28 2024, 12:33 AM

View All 42 Files

Subscribers

Details

Reviewers

Commits

rG3d8562348c9c: fusefs: Address -Wunused-but-set-variable warnings

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 43997
Build 40885: arc lint + arc unit

Event Timeline

markj created this revision.Jan 19 2022, 10:49 PM

Herald added a subscriber: imp. · View Herald TranscriptJan 19 2022, 10:49 PM

markj requested review of this revision.Jan 19 2022, 10:49 PM

Harbormaster completed remote builds in B43997: Diff 101661.Jan 19 2022, 10:50 PM

markj added inline comments.Jan 19 2022, 10:51 PM

sys/fs/fuse/fuse_io.c
525	The need for this went away with commit 84879e46c2bea842c3ad7b1b8b26aeb81946f5a8.
sys/fs/fuse/fuse_node.c
455	I'm not sure if this is an actual bug, though invalidating more than necessary probably isn't a correctness issue.

asomers requested changes to this revision.Jan 19 2022, 11:15 PM

asomers added inline comments.

sys/fs/fuse/fuse_node.c
455	It's deliberate. If we get here, that means the FUSE server changed the file's size even though we had it cached. If it changed the size, then it probably changed other stuff too. That's why it's best to invalidate the cache for the whole file.

This revision now requires changes to proceed.Jan 19 2022, 11:15 PM

Drop left_lbn.

Harbormaster completed remote builds in B43999: Diff 101664.Jan 19 2022, 11:17 PM

asomers accepted this revision.Jan 20 2022, 12:07 AM

This revision is now accepted and ready to land.Jan 20 2022, 12:07 AM

Closed by commit rG3d8562348c9c: fusefs: Address -Wunused-but-set-variable warnings (authored by markj). · Explain WhyJan 20 2022, 2:59 PM

This revision was automatically updated to reflect the committed changes.

markj added a commit: rG3d8562348c9c: fusefs: Address -Wunused-but-set-variable warnings.

Revision Contents
Changeset List

Path

Size

sys/

fs/

fuse/

fuse_internal.c

8 lines

6 lines

2 lines

7 lines

Diff 101661

sys/fs/fuse/fuse_internal.c

Loading...

sys/fs/fuse/fuse_io.c

Loading...

sys/fs/fuse/fuse_node.c

Loading...

sys/fs/fuse/fuse_vnops.c

Loading...