posixshm: Report output truncation from kern.ipc.posix_shm_list
ClosedPublic
Actions

Authored by markj on Jan 16 2022, 10:33 PM.

Details

Reviewers

kib

Commits

rGdc7526170d4c: posixshm: Report output buffer truncation from kern.ipc.posix_shm_list

Summary

PR: 240573
MFC after: 1 week

Test Plan

posixshmcontrol ls still seems to work.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 43945
Build 40833: arc lint + arc unit

Event Timeline

markj created this revision.Jan 16 2022, 10:33 PM

Herald added a subscriber: imp. · View Herald TranscriptJan 16 2022, 10:33 PM

markj requested review of this revision.Jan 16 2022, 10:33 PM

Harbormaster completed remote builds in B43945: Diff 101512.Jan 16 2022, 10:33 PM

markj edited the test plan for this revision. (Show Details)Jan 16 2022, 10:33 PM

kib accepted this revision.Jan 16 2022, 10:41 PM

kib added inline comments.

sys/kern/uipc_shm.c
2057	Or you could assign ENOMEN to error and break still. For oldptr != NULL you would do unneeded work, but this arguably does not matter.

This revision is now accepted and ready to land.Jan 16 2022, 10:41 PM

markj added inline comments.Jan 16 2022, 11:04 PM

sys/kern/uipc_shm.c
2057	I wrote it that way first, but it seems nicer to keep the common case simple.

Closed by commit rGdc7526170d4c: posixshm: Report output buffer truncation from kern.ipc.posix_shm_list (authored by markj). · Explain WhyJan 17 2022, 1:36 PM

This revision was automatically updated to reflect the committed changes.

markj added a commit: rGdc7526170d4c: posixshm: Report output buffer truncation from kern.ipc.posix_shm_list.

Revision Contents
Changeset List

Path

Size

sys/

kern/

uipc_shm.c

3 lines

Diff 101512

View Options

posixshm: Report output truncation from kern.ipc.posix_shm_listClosedPublicActions