Page MenuHomeFreeBSD
Differential D33878

pkgbase: Remove runtime dependency on bootloader
ClosedPublic
Actions

Authored by manu on Jan 13 2022, 4:15 PM.
Tags
None
Referenced Files
F119234767: D33878.diff
Fri, Jun 6, 4:50 PM
Unknown Object (File)
Tue, Jun 3, 2:02 AM
Unknown Object (File)
May 7 2025, 7:19 PM
Unknown Object (File)
Apr 16 2025, 11:49 PM
Unknown Object (File)
Apr 9 2025, 5:48 PM
Unknown Object (File)
Apr 9 2025, 1:40 AM
Unknown Object (File)
Apr 1 2025, 3:53 PM
Unknown Object (File)
Mar 23 2025, 7:35 AM
View All 89 Files
Subscribers
emaste
imp
Contributor Reviews (src)

Details

Reviewers
emaste
Group Reviewers
pkgbase
Commits
rG76947916554f: pkgbase: Remove runtime dependency on bootloader
rG5efa7281a790: pkgbase: Remove runtime dependency on bootloader
Summary

It isn't needed and will cause problem when upgrading to a newer release.

MFC after: 2 weeks
Sponsored by: Beckhoff Automation GmbH & Co. KG

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 43905
Build 40793: arc lint + arc unit

Event Timeline

manu created this revision.Jan 13 2022, 4:15 PM
Herald added subscribers: Contributor Reviews (src), imp. · View Herald TranscriptJan 13 2022, 4:15 PM
manu requested review of this revision.Jan 13 2022, 4:15 PM
Harbormaster completed remote builds in B43903: Diff 101416.Jan 13 2022, 4:16 PM
manu added a reviewer: pkgbase.Jan 13 2022, 4:16 PM
emaste added a subscriber: emaste.Jan 13 2022, 4:19 PM

Can we make bootloader a special case like clibs is? I wondered about duplicate cases but assume that if it's a problem clibs would already be affected?

Do we need a similar treatment for kernel?

manu updated this revision to Diff 101421.Jan 13 2022, 6:26 PM

Address @emaste's comments.

Harbormaster completed remote builds in B43905: Diff 101421.Jan 13 2022, 6:26 PM
manu added a comment.Jan 13 2022, 6:27 PM
In D33878#766116, @emaste wrote:

Can we make bootloader a special case like clibs is? I wondered about duplicate cases but assume that if it's a problem clibs would already be affected?

Everything else seems ok.

Do we need a similar treatment for kernel?

Kernel doesn't need this, there is no dependencies.

emaste accepted this revision.Jan 13 2022, 8:18 PM
This revision is now accepted and ready to land.Jan 13 2022, 8:18 PM
Closed by commit rG5efa7281a790: pkgbase: Remove runtime dependency on bootloader (authored by manu). · Explain WhyJan 14 2022, 9:53 AM
This revision was automatically updated to reflect the committed changes.
manu added a commit: rG5efa7281a790: pkgbase: Remove runtime dependency on bootloader.
manu added a commit: rG76947916554f: pkgbase: Remove runtime dependency on bootloader.Jan 28 2022, 7:11 AM

Revision Contents
Changeset List

PathSize
release/
packages/
3 lines

Diff 101421

View Options

release/packages/generate-ucl.sh

Loading...