Page MenuHomeFreeBSD
Differential D4131

Fix a checksum offloading bug in Hyper-V netvsc driver
ClosedPublic
Actions

Authored by honzhan_microsoft.com on Nov 12 2015, 9:45 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Dec 10, 10:15 AM
Unknown Object (File)
Mon, Dec 2, 1:27 PM
Unknown Object (File)
Sun, Nov 24, 1:17 AM
Unknown Object (File)
Nov 4 2024, 7:12 PM
Unknown Object (File)
Nov 4 2024, 7:12 PM
Unknown Object (File)
Nov 4 2024, 7:12 PM
Unknown Object (File)
Nov 4 2024, 7:12 PM
Unknown Object (File)
Nov 4 2024, 6:46 PM
View All Files
Subscribers
imp

Details

Reviewers
whu
royger
Group Reviewers
Contributor Reviewers (ports)
Commits
rS291156: Ignore the inbound checksum flags when doing packet forwarding in netvsc driver.
Summary

In network forwarding test scenario, the checksum should be calculated again if

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 1110
Build 1114: arc lint + arc unit

Event Timeline

honzhan_microsoft.com updated this revision to Diff 10125.Nov 12 2015, 9:45 AM
honzhan_microsoft.com retitled this revision from to Fix a checksum offloading bug in Hyper-V netvsc driver.
honzhan_microsoft.com updated this object.
Herald added a reviewer: Contributor Reviewers (ports). · View Herald TranscriptNov 12 2015, 9:45 AM
Herald added a subscriber: imp. · View Herald Transcript
honzhan_microsoft.com added a reviewer: whu.Nov 12 2015, 9:49 AM
honzhan_microsoft.com added a reviewer: royger.

Could you please help me review the bug fix?

whu edited edge metadata.Nov 13 2015, 8:20 AM

This has been tested by several customers who were experiencing packet loss on their 10.2 gateway VMs. The patch fixed their problems. I just have one minor comment to add a little detailed comments in the code.

sys/dev/hyperv/netvsc/hv_netvsc_drv_freebsd.c
576

Can you put a little more detailed comment here, say to only check for out bound flags and ignore the inbound ones?

royger accepted this revision.Nov 13 2015, 9:33 AM
royger edited edge metadata.

LGTM, although I'm no networking expert.

@Wei: feel free to add my approved by and commit it when you feel it's ready.

This revision is now accepted and ready to land.Nov 13 2015, 9:33 AM
honzhan_microsoft.com updated this revision to Diff 10221.Nov 16 2015, 2:55 AM
honzhan_microsoft.com edited edge metadata.

refine the patch according to Wei Hu's comments

This revision now requires review to proceed.Nov 16 2015, 2:55 AM
Closed by commit rS291156: Ignore the inbound checksum flags when doing packet forwarding in netvsc driver. (authored by whu). · Explain WhyNov 22 2015, 5:26 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
sys/
dev/
hyperv/
netvsc/
6 lines

Diff 10125

View Options

sys/dev/hyperv/netvsc/hv_netvsc_drv_freebsd.c

Loading...